update spicedb-as-library example #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miparnisari
commented
Jun 25, 2025
| }), | ||
| server.WithHTTPGateway(util.HTTPServerConfig{HTTPEnabled: false}), | ||
| server.WithMetricsAPI(util.HTTPServerConfig{HTTPEnabled: true}), | ||
| server.WithMetricsAPI(util.HTTPServerConfig{HTTPEnabled: false}), |
There was a problem hiding this comment.
It took me ages to figure out that if this is true but the port is already being used, the server stops suddenly! (Feels like a bug in SpiceDB)
There was a problem hiding this comment.
This isn't a bug - it's a port where you are exposing a service that is used, the binary should terminate with an error. Imagine you had a collision on the gRPC port, but happily continued to make the service healthy 🙈
There was a problem hiding this comment.
Yeah, but we could not serve any requests until the metrics server comes up 🤔
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.