update kubernetes example and lint workflow #38
Conversation
| readinessProbe: | ||
| exec: | ||
| command: ["grpc_health_probe", "-v", "-addr=localhost:50051"] |
There was a problem hiding this comment.
Avoids
See https://github.com/grpc-ecosystem/grpc-health-probe?tab=readme-ov-file#grpc_health_probe1
⚠️ Kubernetes has now built-in gRPC health checking capability as generally available. As a result, you might no longer need to use this tool and can use the native Kubernetes feature instead.
There was a problem hiding this comment.
The probes do not support any authentication parameters (like -tls).
That's the reason we've kept using the shipped health probe binary rather than using the native K8s one. I'm ambivalent on using it here; on one hand using the health probe binary is in line with how we run it ourselves, but on the other hand for the purposes of this example, using the built-in is probably fine.
There was a problem hiding this comment.
I've reverted this change. The problem is in the SpiceDB docker image - it's not being built for my architecture arm64
miparnisari
force-pushed
the
update-k8s-example
branch
from
5c32cd9 to
be1968c
Compare
| - uses: "actions/checkout@v3" | ||
| - uses: "actions/checkout@v4" | ||
| - uses: "authzed/actions/yaml-lint@main" | ||
| - uses: "instrumenta/kubeval-action@5915e4adba5adccac07cb156b82e54c3fed74921" |
There was a problem hiding this comment.
https://github.com/instrumenta/kubeval?tab=readme-ov-file#kubeval
NOTE: This project is no longer maintained, a good replacement is kubeconform
miparnisari
force-pushed
the
update-k8s-example
branch
from
be1968c to
0dc858f
Compare
miparnisari
changed the title
miparnisari
force-pushed
the
update-k8s-example
branch
3 times, most recently
from
9814c90 to
63c7037
Compare
miparnisari
force-pushed
the
update-k8s-example
branch
from
63c7037 to
0de9145
Compare
No description provided.