Fix panic on permission check error #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that we nil check the response from a CheckPermission request before attempting to extract the debug info from it. This regression was introduced in authzed#354 where we added support for the new debug info in the response body rather than in HTTP trailers.
alecmerdler
force-pushed
the
fix-debug-panic
branch
from
0c38d70 to
88372b2
Compare
vroldanbet
approved these changes
Mar 23, 2024
|
@alecmerdler feel free to release a patch version 🙏🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that we nil check the response from a CheckPermission request before attempting to extract the debug info from it.
This regression was introduced in #354 where we added support for the new debug info in the response body rather than in HTTP trailers.