-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to run on ROS Melodic #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does d2cc4b9 fix? I would recommend adding more explanation to the commit message. In particular, why was 0.1 chosen?
I don't currently have ROS setup on my Create, so I can't test this. I might get it running again in the next few weeks, but I'm not sure I'll have time. |
This reverts commit d2cc4b9.
@lopsided98 I'm sorry but d2cc4b9 was my mistake to push. I reverted the commit. |
@youtalk Thanks for the patch. I'll try to set aside some time to test it this week and I can work on a release for Melodic. |
This worked fine with my Ubuntu18.04, ROS Melodic, and Create1. |
Solved AutonomyLab/create_robot#54
When I used this package on Ubuntu 18.04 and ROS Melodic, I had the same problem above.
This PR solves it based on AutonomyLab/create_robot#54 (comment)