Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(surround_obstacle_checker): use vehicle stop checker #1031

Merged
merged 2 commits into from
Jul 21, 2022
Merged

fix(surround_obstacle_checker): use vehicle stop checker #1031

merged 2 commits into from
Jul 21, 2022

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 3, 2022 •
edited
Loading

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

In this PR, I modified implementation to use vehicle_state_checker in surround_obstacle_checker in order to commonize function that check whether the vehicle is stopped.

NOTE: Following scenario tests have been PASSED in my local env.

  • UC-F-10-00007-001-case1.yaml
  • UC-F-10-00008-001-case1.yaml
  • UC-F-10-00009-001-case1.yaml

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #1031 (60be891) into main (8433c13) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1031      +/-   ##
========================================
- Coverage   9.66%   9.65%   -0.01%     
========================================
  Files       1099    1099              
  Lines      77299   77378      +79     
  Branches   17789   17789              
========================================
  Hits        7473    7473              
- Misses     62547   62626      +79     
  Partials    7279    7279
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.65% <0.00%> (ø) Carriedforward from 8433c13

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/surround_obstacle_checker/src/node.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8433c13...60be891. Read the comment docs.

@mitsudome-r
Copy link
Member

@satoshi-ota Are you still working on this PR?

@mitsudome-r mitsudome-r reopened this Jun 29, 2022
yukkysaito
yukkysaito approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota
fix(surround_obstacle_checker): use vehicle stop checker
9d85f87 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(surround_obstacle_checker): fix namespace
60be891 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota merged commit ac2df1b into autowarefoundation:main Jul 21, 2022
@satoshi-ota satoshi-ota deleted the fix/use-stop-check-library branch July 21, 2022 04:02
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 22, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@satoshi-ota @boyali
fix(surround_obstacle_checker): use vehicle stop checker (tier4#1031)
81daa7e 
* fix(surround_obstacle_checker): use vehicle stop checker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(surround_obstacle_checker): fix namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@satoshi-ota @boyali
fix(surround_obstacle_checker): use vehicle stop checker (tier4#1031)
e698634 
* fix(surround_obstacle_checker): use vehicle stop checker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(surround_obstacle_checker): fix namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@satoshi-ota @boyali
fix(surround_obstacle_checker): use vehicle stop checker (tier4#1031)
ad51e39 
* fix(surround_obstacle_checker): use vehicle stop checker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(surround_obstacle_checker): fix namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@satoshi-ota
fix(surround_obstacle_checker): use vehicle stop checker (autowarefou…
1b6cb35 
…ndation#1031)

* fix(surround_obstacle_checker): use vehicle stop checker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(surround_obstacle_checker): fix namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@satoshi-ota @boyali
fix(surround_obstacle_checker): use vehicle stop checker (tier4#1031)
6c0f27b 
* fix(surround_obstacle_checker): use vehicle stop checker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(surround_obstacle_checker): fix namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 28, 2023
@TomohitoAndo @kminoda @pre-commit-ci
feat(ndt_scan_matcher): use glog (autowarefoundation#5465) (autowaref…
04d8aa8 
…oundation#1031)

* feat(ndt_scan_matcher): use glog



* style(pre-commit): autofix

* update



* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Feb 2, 2024
@TomohitoAndo @kminoda
@pre-commit-ci @saka1-s
feat(ndt_scan_matcher): use glog (autowarefoundation#5465) (autowaref…
c52d055 
…oundation#1031)

* feat(ndt_scan_matcher): use glog



* style(pre-commit): autofix

* update



* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 25, 2024
@saka1-s @satoshi-ota
@kminoda @TomohitoAndo @pre-commit-ci @maxime-clem @takeshi-iwanari @YoshiRi @soblin @YamatoAndo @0x126 @SakodaShintaro @mehmetdogru @rej55 @kyoichi-sugahara
feat: keep stop policy v0.11.2 (autowarefoundation#1125)
23d651f 
* feat(avoidance): keep stopping until all shift lines are registered

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(map_loader): display curbstone as marker array (autowarefoundation#4958)

display curbstone as marker array

Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* revert refactoring due to cherry-pick

* feat(ndt_scan_matcher): use glog (autowarefoundation#5465) (autowarefoundation#1031)

* feat(ndt_scan_matcher): use glog



* style(pre-commit): autofix

* update



* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(out_of_lane): improve reuse of previous decision (autowarefoundation#1017)

* Do not directly reuse a prev stop point but project it on the new path

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Improve reuse of the previously inserted stop point

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix precision of inserted stop point

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

---------

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* fix(system_monitor): output command line (autowarefoundation#5430) (autowarefoundation#1057)

* fix(system_monitor): output command line



* style(pre-commit): autofix

---------

Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: pull tracking object merger from awf/main

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat(intersection): check path margin for overshoot vehicles on red light (autowarefoundation#5394) (autowarefoundation#1056)

Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fix(ndt_scan_matcher): delete diagnostics thread (autowarefoundation#5532)

Signed-off-by: yamato-ando <Yamato ANDO>
Co-authored-by: yamato-ando <Yamato ANDO>

* fix(ndt_scan_matcher): delete unmerged feature

* fix(ndt_scan_matcher): fixed a lock scope in update_ndt (autowarefoundation#5951)

Fixed the lock scope in update_ndt

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking (autowarefoundation#5842) (autowarefoundation#1075)

fix(utils): fix drivable area expansion logic for zebra zone

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bvp): traffic light state debug (autowarefoundation#1083)

Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>

* fix(traffic_light): stop if the traffic light signal timed out (autowarefoundation#5819) (autowarefoundation#1124)

* fix(traffic_light): stop if the traffic light signal timed out



* fix(traffic_light): fix README format



---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(mpc_lateral_controller): add debug info of qp solver (autowarefoundation#5459) (autowarefoundation#1098)

* add debug info of qp solver



* no info for EigenLeastSquareLLT



* return 0 in base class

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Co-authored-by: Shinnosuke Hirakawa <shinnosuke.hirakawa@tier4.jp>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Mehmet Dogru <48479081+mehmetdogru@users.noreply.github.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@0x126 0x126 Awaiting requested review from 0x126

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoshi-ota @mitsudome-r @yukkysaito