ci(codecov): fix diff coverage #384

KeisukeShima · 2022-02-14T09:27:43Z

Signed-off-by: Keisuke Shima 19993104+KeisukeShima@users.noreply.github.com

Related Issue(required)

Description(required)

After some investigation, it was necessary to merge the coverage diffs with the results from the base branch. See the issue for more details.

Review Procedure(required)

Check CodeCov and coverage report comment on this PR.

Related PR(optional)

autowarefoundation/autoware-github-actions#77

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Read commit-guidelines
Assign PR to reviewer

If you are adding new package following items are required:

Documentation with description of the package is available
A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Commits are properly organized and messages are according to the guideline
PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

* release v0.4.0 * add obstacle avoid param (autowarefoundation#62) * Feature/add stop reason lane change (autowarefoundation#69) * add blocked by obstacle * add stop reason topic to lane change planner * Revert "add blocked by obstacle" This reverts commit 1f5ecdb30c04f7ee70a4b3271bb2099c44752801. * removed ROS1 package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "removed ROS1 package" This reverts commit c914e2e16fed7726f8748e1f936b061f051eaf8f. * add COLCON_IGNORE file to all ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rename *.launch files to *.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * port planning launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add missing porting Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * replace rostopic pub with executable in behavior_planning.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix remapping of topics in launch files Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * modify integer parameters to double parameters Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix arguments in parking.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix remapping of topics in scenario_planning.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Linting: planning_launch (autowarefoundation#38) * Ros2 port autoware launch (autowarefoundation#35) * [autoware_launch] port CMakelists.txt and remove COLCON_IGNORE Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] fix planning_simulator.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] add rviz config Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] first port of autoware_launch Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * lanuch rviz with config file Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * modify launch file for making psim work Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * add vehicle model in launch Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * change from vehicle_model to vehicle_param_file Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * [autoware_launch] add autoware_web_controller and system launch Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add rosbrdige_suite to build_depends.repos Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Update rviz Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * update autoware.rviz Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * remove autoware_ros2.rviz Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: kosuke murakami <kosuke.murakami@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 planning launch (autowarefoundation#59) * [planning_launch] restore file name for ros2 porting Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Add obstacle_stop_planner.yaml (autowarefoundation#82) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add surround obstacle checker options (autowarefoundation#86) * fix slow down param related to tier4/autoware.iv@a9cdcb2 (autowarefoundation#91) * fix parame max_steer_deg (autowarefoundation#92) * add refine_goal_search_radius_range (autowarefoundation#93) * Change default evaluation in motion velocity optimizer (autowarefoundation#97) * Use Linf * Add new line * Add maximum_deceleration parameter (autowarefoundation#98) * Add maximum_deceleration parameter * Change default value * Unable abort lane change (autowarefoundation#102) * add param stoping velocity and fix typo (autowarefoundation#106) * Add a parameter for minimum velocity for lane change (autowarefoundation#109) * Add parameters for collision check for lane change (autowarefoundation#110) * Add a parameter for disable collision check at prepare phase * Add parameters for collision check with predicted_path * Add a parameter for backward buffer for end of lane (autowarefoundation#114) * Add parameters for backward buffer for end of lane * Remove comment out * add extend_distance param (autowarefoundation#107) * add parameter of acc (autowarefoundation#129) Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * fix typo & change static object velocity thres in lane_change_planner (autowarefoundation#104) * change static object velocity thres Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * fix typo Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * Change minimum_lane_change_velocity (autowarefoundation#131) * Feature/update avoidance param (autowarefoundation#140) * update avoidance param Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * disable unnecesarry marker Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * modify min_behavior_stop_margin (autowarefoundation#127) * modify min_behavior_stop_margin Signed-off-by: Yamato Ando <yamato.ando@gmail.com> * Update obstacle_stop_planner.yaml Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * Add expand_stop_range to obstacle_stop_planner.yaml (autowarefoundation#152) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Update obstacle_stop_planner.yaml (autowarefoundation#153) * Visualize echo back goal_pose instead of 2D Nav Goal (autowarefoundation#150) * Visualize echo back goal_pose instead of 2D Nav Goal Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mission_planning.launch Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add surround_obstacle_checker.yaml (autowarefoundation#157) * Add parameter (autowarefoundation#158) * Revert "[planning_launch] restore file name for ros2 porting" This reverts commit 275f0df232323bf24627adea9cb08888c250625e. * fix namespace Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix relay Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [planning_launch]: Add vehicle_param_file for turn signal decider Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [planning_launch]: Change topic type of lane change approval Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Satoshi Tanaka <st14.828soccer@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: hiroaki-ishikawa-t4 <57431939+hiroaki-ishikawa-t4@users.noreply.github.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 fix packages (autowarefoundation#64) * add vehicle_param_file to simple planning simulator * add vehicle_param_file to lane change planner * Rename ROS-related .yaml to .param.yaml (autowarefoundation#65) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add missing '--' Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix livox param name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2 update v0.9.0 (autowarefoundation#67) * Add pose history into rviz config Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add blocked by obstacle option (autowarefoundation#164) * fix tab name (autowarefoundation#166) * disenable ndt visualization (autowarefoundation#169) * disenable ndt visualization * change alpha * dont visualize position covariance Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * change global frame to map (autowarefoundation#171) * add param (autowarefoundation#156) Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Ros2 fix topic name part1 (autowarefoundation#83) * Fix topic name for behavior_velocity_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of lane_change_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of freespace_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for freespace_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix typo in planning launch (autowarefoundation#92) * Fix typo in planning launch * Fix remaining errors * Fix various typos in launch files (autowarefoundation#97) * add use_sim-time option (autowarefoundation#99) * Format launch files (autowarefoundation#178) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Sync public repo (autowarefoundation#185) * add tier4 usbcam (autowarefoundation#104) * add tier4 usbcam * change version * tier4/ros2 * Ros2 vehicle info param server (autowarefoundation#96) * add vehicle info param server * delete vehicle param file Co-authored-by: taikitanaka <ttatcoder@outlook.jp> * Ros2 fix topic name part2 (autowarefoundation#89) * Fix topic name for traffic_light_classifier Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for traffic_light_visualization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> * Ros2 lsim test (autowarefoundation#186) * Add group to launch file for var scope Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add use_sim_time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Use set_parameter for use_sim_time (autowarefoundation#198) * Use set_parameter for use_sim_time Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add default parameter for scenario simulator Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add container launch for planning (autowarefoundation#205) * Add container launch for planning Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix porting miss * fix lane_driving.launch.xml * Add missing parameters Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: taichiH <azumade.30@gmail.com> * Rename AstarNavi to FreespacePlannerNode (autowarefoundation#213) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typos in launch files (autowarefoundation#231) * Fix typos in launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Format launch files (autowarefoundation#228) * Format launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Format launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix topic name of external traffic light input (autowarefoundation#236) * Add namespace to behavior_velocity_planner (autowarefoundation#252) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo applygin->applying (autowarefoundation#304) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add description for planning_launch autowarefoundation#335 * add README.md and svg files (autowarefoundation#328) * add md and svg * fix typo * fix typo * fix word * fix typo * add lack of things * Update README * fix depending packages * fix word * Add autoware api (autowarefoundation#376) * Add external api adaptor (autowarefoundation#267) * Add external api adaptor * Add api adaptor to logging simulator Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add engage status output Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add internal api adaptor (autowarefoundation#273) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add map hash generator (autowarefoundation#319) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add autoware api launch (autowarefoundation#326) * Add autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Apply autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add deprecated comment Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove unused parameter (autowarefoundation#325) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add api parameter (autowarefoundation#341) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add start request API (autowarefoundation#321) * Add use start request option Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Feature external cmd selector heartbeat (autowarefoundation#356) * Rename external command topic Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Modify command topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Rename remote_cmd_converter Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove gate mode from external command Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix latest external command name (autowarefoundation#361) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix merge conflict Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * change external traffic light topic name in behavior velocity planner (autowarefoundation#310) * fix topic * change internal topic name Co-authored-by: yabuta <makoto.yabuta@tier4.jp> * Merge pull request autowarefoundation#359 from tier4/feature/add_plannig_error_monitor (autowarefoundation#365) * Feature/add virtual traffic light planner (autowarefoundation#317) * Fix pre-commit (autowarefoundation#407) * Fix pre-commit errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix parameter name (autowarefoundation#470) * Feature/porting behavior path planner (autowarefoundation#300) * modify behavior_planning launch for behavior_path_planner with lane_c… (autowarefoundation#239) * modify behavior_planning launch for behavior_path_planner with lane_change_only config Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove avoidance & side_shift related code Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix launcher and add config files and change obstacle avoid param * Add new line * Fix visualization and remove multiple args * Enable auto approve path change Co-authored-by: rej55 <rej55.g@gmail.com> Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add param in behavior_path_planner (autowarefoundation#255) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix param (autowarefoundation#251) * Fix typo Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: rej55 <rej55.g@gmail.com> * Feature/porting motion velocity smoother (autowarefoundation#302) * Launch motion_velocity_smoother (autowarefoundation#215) * Launch motion_velocity_smoother * Change params * Fix parameter files * Fix Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix/smoother trajectory ds (autowarefoundation#249) * Add parameter * Fix * Fix * change launcher parameter (autowarefoundation#265) * Feature/smoother resampling (autowarefoundation#269) * change launcher parameter * add new parameter Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com> * Master sync parking module (autowarefoundation#303) * Add namespace Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add freespace planner config file Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add missing import Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * update rviz config & planner params (autowarefoundation#305) Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> * Feature/porting occlusion spot (autowarefoundation#309) * add occulusion_spot marker (autowarefoundation#266) * add blindspot marker * to occlusion spot slow down * remove debug info from marker (autowarefoundation#287) * remove debug info from marker * remove debug arrow * fix format * update behavior launch * apply pep8 * fix format Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * Use multithread for lane driving planning (autowarefoundation#327) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix import order of parking.launch.py (autowarefoundation#347) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add analytical smoother config (autowarefoundation#360) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * update acc param (autowarefoundation#358) * add rosparam for vehicle center optimization (autowarefoundation#362) * update ros param for .iv (autowarefoundation#353) * update ros param for .iv * forward fixing mpt time: 3.0->1.0 * Fix/obstacle avoid revert some improvements (autowarefoundation#381) * Revert "update ros param for .iv (autowarefoundation#353)" This reverts commit f7f341a. * Revert "add rosparam for vehicle center optimization (autowarefoundation#362)" This reverts commit 78bbf70. * update side shift param (autowarefoundation#370) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add yaml & load lane following params (autowarefoundation#377) * add pull over/out module (autowarefoundation#430) add yaml file and modify BT tree file path modify parameter file add parameter add use_dynamic_object flag in pull out param delete unncesarry parameters delete unnecessary param merge change for jpntaxi delete blank line modify BT file name modify launch file * Update behavior path planner launch files (autowarefoundation#433) * update launch parameters for behavior_path_planner Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * update param at experiment Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix indent Co-authored-by: TakaHoribe <horibe.takamasa@gmail.com> * Fix for pre-commit (437) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * change threshold_distance_object_is_on_center to 1.0 (autowarefoundation#441) Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * delete optimizer (autowarefoundation#456) * add params for acceleration prevention (autowarefoundation#454) (autowarefoundation#457) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Feature/use external velocity limit selector (autowarefoundation#460) * use external velocity limit selector * add common planning params * update yaml params * Feature/add slow down params (autowarefoundation#448) * add/update slow down params * topic remap * update topic name * Fix/use common param (autowarefoundation#465) * Change formatter to black (autowarefoundation#488) * Update pre-commit settings * Apply Black * Replace ament_lint_common with autoware_lint_common * Update build_depends.repos * Fix build_depends * twist -> odometry (autowarefoundation#109) Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> * Auto/fix launch (autowarefoundation#110) * fix namespace * remove dynamic_object_visualization * fix rviz * remove unused depend/launcher (autowarefoundation#112) * Fix remapping in control.launch.py (autowarefoundation#115) * Fix remappings * Add comment * Sync .auto branch with the latest branch in internal repository (autowarefoundation#120) * Disbale intersection polygon marker (autowarefoundation#483) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Merge pull request autowarefoundation#384 from tier4/feature/no_stopping_area Feature/no stopping area Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * Update traffic light topic name (autowarefoundation#131) * Update traffic light topic name Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update traffic light topic name in perception Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix no ground pointcloud topic name (autowarefoundation#134) Signed-off-by: j4tfwm6z <proj-jpntaxi@tier4.jp> Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp> * auto/fix occupancy grid map topic name (autowarefoundation#137) * fix/rename segmentation namespace (autowarefoundation#139) * fix namespace: rviz config * fix namespace: planning stack * rename segmentatino directory * fix namespace: perception stack * add vehicle info parameter Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * ci(pre-commit): autofix * remove unused import * remove unused import Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Satoshi Tanaka <st14.828soccer@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: hiroaki-ishikawa-t4 <57431939+hiroaki-ishikawa-t4@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: taichiH <azumade.30@gmail.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: kyoichi sugahara <81.s.kyo.19@gmail.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* release v0.4.0 * pointcloud_map_path form autoware_launch as optional (autowarefoundation#45) * pointcloud_map_path form autoware_launch as optional * add lanelet2_map_path * use map_file argments under map_path * Fix unnecessary "default" tag to "value" Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * add some dependencies (autowarefoundation#54) * Add some scenario-simulation specifiec parameters as arguments (autowarefoundation#57) * Add some scenario-simulation specifiec parameters as arguments * Update arg to pass 'initial_engage_state' to simple_planning_simulator * Add new optional argument 'rviz_args' * Rename some roslaunch arguments * Remove unneeded arguments * Fix typo (autowarefoundation#63) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add obstacle avoid param (autowarefoundation#62) * Logging simulator (autowarefoundation#65) * Add logging_simulator.launch Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> * Don't load env when launch driver is false Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> * Launch vehicle description in logging simulator (autowarefoundation#67) Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> * add autoware api launcher (autowarefoundation#64) * add blocked by obstacle (autowarefoundation#68) * Fix turn signal topic name (autowarefoundation#75) * Revert "Fix turn signal topic name (autowarefoundation#75)" (autowarefoundation#76) This reverts commit f384b9f7b2e59b7f048926e7eb0fe7c936f5cd3b. * Fix namespace in autoware.rviz (autowarefoundation#78) * Fix/turn signal topic name (autowarefoundation#77) * removed ROS1 package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "removed ROS1 package" This reverts commit 1e33e7e3f3e839bcdf623f9e3b4b6a14dd4ec35a. * add COLCON_IGNORE file to all ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rename *.launch files to *.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Ros2 port autoware launch (autowarefoundation#35) * [autoware_launch] port CMakelists.txt and remove COLCON_IGNORE Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] fix planning_simulator.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] add rviz config Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] first port of autoware_launch Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * lanuch rviz with config file Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * modify launch file for making psim work Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * add vehicle model in launch Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * change from vehicle_model to vehicle_param_file Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * [autoware_launch] add autoware_web_controller and system launch Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add rosbrdige_suite to build_depends.repos Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Update rviz Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * update autoware.rviz Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * remove autoware_ros2.rviz Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: kosuke murakami <kosuke.murakami@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update rviz config for vehicle rviz plugins (autowarefoundation#41) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 fix packages (autowarefoundation#64) * add vehicle_param_file to simple planning simulator * add vehicle_param_file to lane change planner * Rename ROS-related .yaml to .param.yaml (autowarefoundation#65) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add missing '--' Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix livox param name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2 v0.8.0 autoware launch (autowarefoundation#58) * [autoware_launch] ros2-porting: v0.5.0 to v0.8.0 Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Cleanup autoware and logging simulator launch * Add .xml extention * Fix missing arguments * Fix tag * Fix web controller launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update rviz Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autoware_launch] Fix yaml name Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autoware_launch] Cleanup dependencies Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autoware_launch]: Fix missing arguments (autowarefoundation#66) Signed-off-by: Autoware <autoware@tier4.jp> Co-authored-by: Autoware <autoware@tier4.jp> * Ros2 update v0.9.0 (autowarefoundation#67) * Add pose history into rviz config Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add blocked by obstacle option (autowarefoundation#164) * fix tab name (autowarefoundation#166) * disenable ndt visualization (autowarefoundation#169) * disenable ndt visualization * change alpha * dont visualize position covariance Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * change global frame to map (autowarefoundation#171) * add param (autowarefoundation#156) Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Sync with Ros2 v0.8.0 beta (autowarefoundation#71) * update sensing launch to support aip_x1 (autowarefoundation#69) Signed-off-by: taichiH <azumade.30@gmail.com> * fix logging_simulator_bug (autowarefoundation#68) Signed-off-by: taichiH <azumade.30@gmail.com> * fix aip_x1 param (autowarefoundation#70) Signed-off-by: taichiH <azumade.30@gmail.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> * temporary disable steering angle plugin to avoid RVIZ2 to crash (autowarefoundation#76) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix rviz settings (autowarefoundation#77) * Points -> Squares * disable road_lanelets * visualize path of dynamic object * fix durability policy of route_marker * fix topic name * fix topic name of check point * fix some options about object * add clock_publisher and autoware_version (autowarefoundation#79) * add clock_publisher and autoware_version Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * update package.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * update build_depends.repos Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix CI Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Fix typo in rviz config (autowarefoundation#80) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fixed typo and added AW_ROS2_USE_SIM_TIME setting (autowarefoundation#81) Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp> * Fix point size in rviz (autowarefoundation#84) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Use sensor data qos for pointcloud (autowarefoundation#82) Signed-off-by: Autoware <autoware@tier4.jp> Co-authored-by: Autoware <autoware@tier4.jp> * Ros2 fix topic name part1 (autowarefoundation#83) * Fix topic name for behavior_velocity_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of lane_change_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of freespace_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for freespace_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix various typos in launch files (autowarefoundation#97) * add use_sim-time option (autowarefoundation#99) * Format launch files (autowarefoundation#178) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace doc by description (autowarefoundation#182) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Sync public repo (autowarefoundation#185) * add tier4 usbcam (autowarefoundation#104) * add tier4 usbcam * change version * tier4/ros2 * Ros2 vehicle info param server (autowarefoundation#96) * add vehicle info param server * delete vehicle param file Co-authored-by: taikitanaka <ttatcoder@outlook.jp> * Ros2 fix topic name part2 (autowarefoundation#89) * Fix topic name for traffic_light_classifier Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for traffic_light_visualization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> * Ros2 lsim test (autowarefoundation#186) * Add group to launch file for var scope Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add use_sim_time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add vehicle info param server into logging simulator (autowarefoundation#194) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Use set_parameter for use_sim_time (autowarefoundation#198) * Use set_parameter for use_sim_time Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add default parameter for scenario simulator Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add control composed launch (autowarefoundation#201) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add param for psim v2 (autowarefoundation#197) * add param for psim v2 Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * Update to pass var 'scenario_simulation' to dummy_perception_publisher * Update dummy_perception_publisher's arg-name Co-authored-by: yamacir-kit <httperror@404-notfound.jp> * Feature/porting v0.9.1 master (autowarefoundation#202) * add simulation arg (autowarefoundation#174) * add simulation arg * add comment * change arg name * add parameter use_empty_dynamic_object_publisher into perception.launch (autowarefoundation#176) Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> * Add vehicle info launch for setting vehicle info param (autowarefoundation#199) * Add vehicle info launch for setting vehicle info param Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add comment for global parameters section Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix year and apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ready vehicle info param Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove vehicle info param server from logging simulator (autowarefoundation#211) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add map.launch.py (autowarefoundation#212) * Add map.launch.py Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update map.launch.xml Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Rename parameter for lanelet2 map path Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Exclude dummy_perception_publisher.launch.xml if is scenario_simulation (autowarefoundation#230) * Remove clock publisher (autowarefoundation#217) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fixup for autowarefoundation#217 (autowarefoundation#254) * Fixup for autowarefoundation#217 Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add global_params.launch.py (autowarefoundation#260) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add time panel (autowarefoundation#233) * Move global_params.launch.py and vehicle_info.launch.py to autoware_global_parameter_loader (autowarefoundation#282) * Move global_params.launch.py and vehicle_info.launch.py to autoware_global_parameter_loader Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add exec_depend Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add descriptions for autoware_launch autowarefoundation#329 * add README.md and svg files (autowarefoundation#328) * add md and svg * fix typo * fix typo * fix word * fix typo * add lack of things * Update README * fix depending packages * fix word * Add autoware api (autowarefoundation#376) * Add external api adaptor (autowarefoundation#267) * Add external api adaptor * Add api adaptor to logging simulator Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add engage status output Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add internal api adaptor (autowarefoundation#273) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add map hash generator (autowarefoundation#319) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add autoware api launch (autowarefoundation#326) * Add autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Apply autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add deprecated comment Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove unused parameter (autowarefoundation#325) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add api parameter (autowarefoundation#341) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add start request API (autowarefoundation#321) * Add use start request option Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Feature external cmd selector heartbeat (autowarefoundation#356) * Rename external command topic Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Modify command topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Rename remote_cmd_converter Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove gate mode from external command Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix latest external command name (autowarefoundation#361) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix merge conflict Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * change external traffic light topic name in behavior velocity planner (autowarefoundation#310) * fix topic * change internal topic name Co-authored-by: yabuta <makoto.yabuta@tier4.jp> * Feature/add virtual traffic light planner (autowarefoundation#317) * Move autoware api launch files (autowarefoundation#387) * Fix misspell in rviz config (autowarefoundation#392) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * update rviz config (autowarefoundation#399) * update rviz config * update config * Fix pre-commit (autowarefoundation#407) * Fix pre-commit errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add polar grid into rviz config (autowarefoundation#458) * Add simulator_launch package (autowarefoundation#459) * Add simulator_launch package * add argument * fix depend order * add argument * move dummy_perception_publisher * add arg for dummy_perception_publisher * Update simulator_launch/launch/simulator.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * add steering angle (autowarefoundation#476) * Move simple_planning_simulator to simulator_launch (autowarefoundation#462) * move simple_planning_simulator * add simulation arg to logging_simulator.launch * delete unused argument * add arguments for logging simulation * change default value * update README * add default value to simulator arg * restore vehicle_simulation arg * Add sensor_model to system_launch (autowarefoundation#480) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * hide traffic light id by default (autowarefoundation#286) Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> * Feature/porting behavior path planner (autowarefoundation#300) * modify behavior_planning launch for behavior_path_planner with lane_c… (autowarefoundation#239) * modify behavior_planning launch for behavior_path_planner with lane_change_only config Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove avoidance & side_shift related code Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix launcher and add config files and change obstacle avoid param * Add new line * Fix visualization and remove multiple args * Enable auto approve path change Co-authored-by: rej55 <rej55.g@gmail.com> Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add param in behavior_path_planner (autowarefoundation#255) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix param (autowarefoundation#251) * Fix typo Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: rej55 <rej55.g@gmail.com> * update rviz config & planner params (autowarefoundation#305) Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> * Feature/porting occlusion spot (autowarefoundation#309) * add occulusion_spot marker (autowarefoundation#266) * add blindspot marker * to occlusion spot slow down * remove debug info from marker (autowarefoundation#287) * remove debug info from marker * remove debug arrow * fix format * update behavior launch * apply pep8 * fix format Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * Feature/porting camera lidar fusion (autowarefoundation#316) * Feature/camera lidar fusion (autowarefoundation#248) * change camera lidar fusion node * change default mode of object recognition * change spilit range parameter from 10 to 30 (autowarefoundation#272) Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * add underscore to marker namespace (autowarefoundation#323) Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> * Feature/hide verbose marker (autowarefoundation#322) * tmp : enable slow down * hide verbose markers * Revert "tmp : enable slow down" This reverts commit 5ad32c5903866d9cf946cc47b0b35cefa359d502. * update rviz tool bar Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> * update rviz config ( add shoulder road lanelets ) (autowarefoundation#420) * update rviz config * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Fix for pre-commit (437) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change formatter to black (autowarefoundation#488) * Update pre-commit settings * Apply Black * Replace ament_lint_common with autoware_lint_common * Update build_depends.repos * Fix build_depends * Auto/fix launch (autowarefoundation#110) * fix namespace * remove dynamic_object_visualization * fix rviz * change topic name for rviz plugin (autowarefoundation#114) * Auto/launcher ground segmentation (autowarefoundation#117) * add base line launch * add ground_segmentation launcher * run pre-commit * clean up * fix coding style * fix topic name * fix yaml params * fix loader name * rename components * improve implementation * Sync .auto branch with the latest branch in internal repository (autowarefoundation#120) * Disbale intersection polygon marker (autowarefoundation#483) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Merge pull request autowarefoundation#384 from tier4/feature/no_stopping_area Feature/no stopping area Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * fix turn signal to indicators (autowarefoundation#123) * fix no ground points topic name (autowarefoundation#125) * support x1 perception config (autowarefoundation#129) * support x1 perception config * remove product config * update launch.py * maintain some filters params in yaml file * add function to create elevation map pipeline * add param to yaml * fix/rviz perception config (autowarefoundation#138) * fix/rename segmentation namespace (autowarefoundation#139) * fix namespace: rviz config * fix namespace: planning stack * rename segmentatino directory * fix namespace: perception stack * fix/add arg in order to disable dummy_perception_publisher from command line (autowarefoundation#144) * change topic name for predicted trajectory (autowarefoundation#145) * feature/use common pointcloud container (autowarefoundation#147) * add container argument * load composable node to pointcloud_container * fix autoware_launch * enable multi-thread * improve readability * add vehicle_info_param_file Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * ci(pre-commit): autofix * fix launch files and remove api launch Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * ci(pre-commit): autofix * add initial pose relay Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Yamasaki Tatsuya <httperror@404-notfound.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com> Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

kenji-miyake · 2022-02-16T12:46:08Z

Waiting for #372 (comment).

.github/workflows/build-and-test-differential.yaml

.github/workflows/build-and-test.yaml

codecov.yaml

* release v0.4.0 * Add map diag (autowarefoundation#688) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change default value of disengage_on_route (autowarefoundation#703) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change localization diag namespace (autowarefoundation#718) * Change default value of output_diagnostics_topic Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove localization_diagnostic.js from web_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Integrate localization diag to diagnostic_aggregator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Delete old and unused publisher Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Support error in autoware state (autowarefoundation#728) * Support Error in autoware_state_monitor Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Refactor autoware_state_monitor Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Wait after planning completed Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Integrate FailedToArriveGoal and Error into Emergency state Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove override after arrived goal in autoware_state_monitor (autowarefoundation#737) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Improve autoware state monitor diag (autowarefoundation#792) * Add ok_list to stats Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use key-value Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add ok_list Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 470b35a4a07baca60033f7b363dba2f4279ff9c7. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * [WIP] ROS2 Porting: autoware_state_monitor (autowarefoundation#81) * Fix CMake and package.xml - Remove topic_tools deps in package.xml - Fix cmake refs - Build just core without other deps * Remove colcon ignore * Convert CMake to ament_cmake_auto * Fix package.xml with correct deps - Remove topic tools * Convert yaml files to be ROS2 compliant - Previous XmlRpc was used to collect yaml array like structures - Use _configs.names string array to locate config.<name>.<field> - Will need to convert the way the parametersa are retrieved * First pass - make compile * Port headers - Change the name of arrived goal for consistency - Port state machine - Port diagnostics wrapper methods * Add subscription, publisher and timers - Add simple parameters - Add back functionality - Add topic state functionality - Add functionality * Add configuration parameter implementations * Add launch files and clean up - Remove commented code from cmake and package.xml - Remove rosconsole.h * Clean up - Remove changes to autoware_sysytem_msgs - remove comments * Added types to the launch files - Make type arrays to allow for multiple types * Add rclcpp_generic implementation for subscriptions - Add the callback method back - Include exec_depends in package.xml * Clean up - Remove boost dependencies - Remove commented out dependencies - Remove comments * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * Add linters and fix some clang-tidy warnings (autowarefoundation#205) * [autoware_state_monitor] fix parameter in autoware_state_monitor.planning_simulation.yaml (autowarefoundation#244) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Modify autoware state monitor (autowarefoundation#288) * comment out param config Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * fix minor issues Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * change engage from bool to control msg (autowarefoundation#292) Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * Ros2 v0.8.0 autoware state monitor (autowarefoundation#277) * Ros2 v0.8.0 engage (autowarefoundation#342) * [autoware_vehicle_msgs]: Add engage message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [as]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [awapi_awiv_adapter]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [web_controller]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [vehicle_cmd_gate]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autoware_state_monitor]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autoware_control_msgs]: Remove EngageMode message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [simple_planning_simulator]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix invalid exception handling (autowarefoundation#344) * remove invalid exception handling Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * remove unnecessary topics Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * Ros2 v0.8.0 fix packages (autowarefoundation#351) * add subscription to QoS * add vihicle_param _file to simple_planning_sim * update cmake/packages.xml * comment out unused parameter * apply lint * add vehicle_info_util to lane_change_planner * add vehicle_info_util to vehicle_cmd_gate * fix cmake of simple planning simulator * update cmake/packages.xml of vehicle cmd gate * apply lint * apply lint * add latch option to autoware_state_monitor * delete unused comment * fix implement miss in autoware_state_monitor * Rename ROS-related .yaml to .param.yaml (autowarefoundation#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix overlooked parameters Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2 v0.8.0 fix packages2 (autowarefoundation#354) * fix topic name * fix duration rate * fix sensing.yaml * fix topic name * add latch-option to autoware_state_monitor * fix timer callback * fix autoware state monitor config * fix sensing.yaml * Add parameter args to autoware_state_monitor.launch (autowarefoundation#1175) (autowarefoundation#385) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Feature/Add route cancel service (autowarefoundation#384) * Feature/Add route cancel service (autowarefoundation#1100) * Feature/Add route cancel service Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add guard Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix service name in launch Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * remove spin_some within service callback functions Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * apply ament_uncrustify Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * change wait time for state transition (autowarefoundation#416) * Sensor data qos (autowarefoundation#407) * Use sensor data qos for pointcloud preprocessor Signed-off-by: Autoware <autoware@tier4.jp> * Use sensor data qos for pointcloud Signed-off-by: Autoware <autoware@tier4.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Use sensor data qos for livox tag filter and vector map filter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Autoware <autoware@tier4.jp> * Fix typo in system module (autowarefoundation#434) * Fix typo in system module * Change variable name * Move comments * Apply uncrustify * add use_sim-time option (autowarefoundation#454) * add missing topic to topic config list (autowarefoundation#1224) * remove pointcloud from state_monitor (autowarefoundation#1236) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Use integrated generic subscription (autowarefoundation#1342) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * suppress warnings for autoware_state_monitor (autowarefoundation#1722) * suppress warnings for autoware_state_monitor * fix style * re fix style * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Sync v1.3.0 (autowarefoundation#1909) * Add elevation_map to autoware_state_monitor (autowarefoundation#1907) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Disable saving elevation map temporarily (autowarefoundation#1906) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * sync rc (autowarefoundation#1930) * Remove elevation_map from autoware_state_monitor (autowarefoundation#1922) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Use base_ref (autowarefoundation#1925) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Add autoware api (autowarefoundation#1979) * suport auto recovery on autoware_state_monitor (autowarefoundation#2006) * disable emergency check if hazard_status is not received (autowarefoundation#2024) * suppress warnings for system directory autowarefoundation#2046 * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Added warning about lookupTransform failure in autoware_status_monitor (autowarefoundation#2099) * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [autoware state monitor] support autoware.auto msg (autowarefoundation#521) * support autoware.auto msg * add readme * remove unused code * remove emergency state * stop to subscribe hazard_status * remove VehicleStateReport/VehicleStateCommand/VehicleControlCommand (autowarefoundation#549) * fix autoware_error_monitor * fix state monitor * fix emergency handler(vehicle_state_report) * fix emergency Handler(vehicle_state_command) * fix shift_decider * fix emergency_handler(vehicle_control_command) * fix topic name * fix readme * Update system/autoware_state_monitor/Readme.md Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * fix format * Update system/autoware_state_monitor/launch/autoware_state_monitor.launch.xml Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * fix typo Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * [autowere_web_controller/autoware_state_monitor/emergency_handler]fix some packages (autowarefoundation#603) * fix vehicle_engage.js * fix autoware_state_monitor param * fix emergency_handler * oh * update autoware_state.js * [autoware_state_monitor]route -> had_map_route (autowarefoundation#635) * route -> had_map_route * Rename Readme.md to README.md Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> * Fix autoware monitors readme (autowarefoundation#629) * Fix readme of autoware_state_monitor * Fix readme of autoware_error_monitor * adapt to actuation cmd/status as control msg (autowarefoundation#646) * adapt to actuation cmd/status as control msg * fix readme * fix topics * fix remaing topics * as to pacmod interface * fix vehicle status * add header to twist * revert gyro_odometer_change * revert twist topic change * revert unchanged package * Fix topic name in autoware_state_monitor (autowarefoundation#667) * Fix no ground pointcloud topic name (autowarefoundation#733) Signed-off-by: j4tfwm6z <proj-jpntaxi@tier4.jp> Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp> * fix/rename segmentation namespace (autowarefoundation#742) * rename segmentation directory * fix namespace: system stack * fix namespace: planning * fix namespace: control stack * fix namespace: perception stack * fix readme Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Yohei Mishina <66298900+YoheiMishina@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

codecov.yaml

KeisukeShima · 2022-03-09T05:39:43Z

Related following comment, I'd like to explain about build and test flow.
#384 (comment)

Current implementation is:

If I move all coverage-related process to the test action, it would look like this:

This is not suitable for use cases where users only want to run tests.
It also assumes dependencies between branches by referencing the coverage cache.

Therefore, I would like to split the test and coverage jobs.

@kenji-miyake How do you feel about this change? If you agree with me, I would like to create PR.

kenji-miyake · 2022-03-15T04:19:37Z

@KeisukeShima Thank you for the clear diagrams!
But I feel like I don't want to refer colcon-test from colcon-test-coverage.
Since it is natural to calculate the code coverage in tests, it's good to output from colcon-test and refer it in the later stage.

It is almost the same as the current implementation, but you can make it an action to be reusable.

What do you think about it?

.github/workflows/build-and-test.yaml

KeisukeShima · 2022-03-15T05:00:33Z

@KeisukeShima Thank you for the clear diagrams! But I feel like I don't want to refer colcon-test from colcon-test-coverage. Since it is natural to calculate the code coverage in tests, it's good to output from colcon-test and refer it in the later stage.

I have updated the diagram to reflect your ideas.
I think it is acceptable. In that case, I think it is necessary to change the action name from colcon-test-coverage to filter-coverage, as it would be easier for users to understand.

It is almost the same as the current implementation, but you can make it an action to be reusable.

Both yours and my workflow can be made reusable. After we agree on a design, I will create a new action in autoware-github-actions.

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>

KeisukeShima · 2022-03-30T06:34:29Z

I found a solution!!
The carryforward flags gives a perfect differential coverage reports. Internally, Codecov searches base coverage and merge it.

Here is my repository for evaluation.
KeisukeShima/ros2-codecov-example#2
https://app.codecov.io/gh/KeisukeShima/ros2-codecov-example/compare/2/overview

@kenji-miyake Could you re-review this PR?

kenji-miyake · 2022-03-30T11:52:36Z

Official Doc: https://docs.codecov.com/docs/carryforward-flags

kenji-miyake · 2022-03-30T11:53:17Z

codecov.yaml

+        target: auto
+      - name_prefix: patch-
+        type: patch
+        target: auto


Could you explain all other parameters for other people?

coverage section

coverage section defines project and patch statuses.

project means the whole coverage change on the repository.

patch means the differential coverage change on the pull request or single commit.

default defines default target value. If you need to modify it for specific flags, you can add new keys.

Each section has target key.
Target can choose a minimum coverage ratio that the commit must meet to be considered a success.
auto will use the coverage from the base commit (pull request base or parent commit) coverage to compare against.

Reference:
https://docs.codecov.com/docs/commit-status#project-status

comment section

By default, any flags that are carried forward will not show up in the pull request / merge request in your code host (Github, Gitlab, or Bitbucket) in the status checks and/or the pull request comments.

show_carryforward_flags: true: if any flag coverage was carried forward, the flags table will have an additional column labeled “Carriedforward” indicating which flags had coverage carried forward

Reference:
https://docs.codecov.com/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment

flag_management section

This is a recommended approach to manage flags.
https://docs.codecov.com/docs/flags#recommended-automatic-flag-management

default_rules defines default rules for all flags.
carryforward: All flags are assumed to carry forward flags.

statuses: Report coverage statuses for each flag. The target and type are the same as coverage section. name_prefix adds prefix for each flag.

kenji-miyake · 2022-03-30T11:56:30Z

Also, could you explain your test results?
I can't understand it well because I don't know what is the wrong state and what is the correct one.
So it would be great to add some comparisons of before/after.

KeisukeShima · 2022-03-31T07:23:53Z

Also, could you explain your test results? I can't understand it well because I don't know what is the wrong state and what is the correct one. So it would be great to add some comparisons of before/after.

Wrong state
add if statement KeisukeShima/ros2-codecov-example#1

Note the Diff.
Diff shows a decrease in the number of files, even though there is no increase or decrease in the number of files. This indicates that coverage is not being reported accurately.

Correct state
Feat/use different flag KeisukeShima/ros2-codecov-example#2

The total flag is the coverage calculated on the base commit of the main branch. It is not calculated in this PR, but inherits the value from the base commit.
The differential flag is the partial coverage calculated in this PR.
Note the Diff. There is no change in the number of files.

kenji-miyake

I've confirmed the behavior was improved and it generally looks good to me. Added some small comments.

codecov.yaml

kenji-miyake · 2022-04-05T16:45:55Z

.github/workflows/build-and-test.yaml

@@ -46,3 +46,4 @@ jobs:
          files: ${{ steps.test.outputs.coverage-report-files }}
          fail_ci_if_error: false
          verbose: true
+          flags: total


I guess no flag means total? 🤔 Is it correct?

Suggested change

flags: total

A total flag is required when using the carry-forward flag feature.

Reference https://docs.codecov.com/docs/carryforward-flags

In that case, what's the difference between project and project-total?

Also, if you delete the flag here, what happens? Will it raise an error? 🤔
I think the carry-forward feature isn't required here because all tests are executed.

Hmm, okay. Let's merge this and watch it for a while.

Also, if you delete the flag here, what happens? Will it raise an error? thinking I think the carry-forward feature isn't required here because all tests are executed.

No, no error occurs. However, the diff coverage reported in the PR comments will be incorrect.

I think the carry-forward feature isn't required here because all tests are executed.

I think you misunderstand the carry-forward feature.

I think the carry-forward feature isn't required here because all tests are executed.

I think you misunderstand the carry-forward feature.

Sorry for being rude. But I had the same mistake.

When you encounter a problem, it's "professional" if you can explain it clearly so that everyone won't get in trouble. 👍

Thank you! Merging.
Before that, I will attempt to explain a few things. (It would be best if Codecov's reference is helpful...)

If there is no total flag

codecov receives the diff coverage calculated by PR.

The coverage computed in the base branch is not used. This is because the coverage with the carryforward flag does not exist in the base branch.

Reports built on diff coverage will be incomplete.

If the total flag is present

codecov receives the diff coverage calculated by PR.

It refers to the coverage computed in the base branch. Because the coverage with the carryforward flag exists in the base branch.

codecov completes reports that are not present in the diff coverage with the base coverage.

Reports created based on the coverage will be complete.

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* ci(codecov): fix diff coverage Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> * Update codecov.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

…ing_area Feature/no stopping area

…ing_area Feature/no stopping area Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

…warefoundation#120) * Disbale intersection polygon marker (autowarefoundation#483) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Merge pull request autowarefoundation#384 from tier4/feature/no_stopping_area Feature/no stopping area Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

…utowarefoundation#384) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* ci(codecov): fix diff coverage Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> * Update codecov.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

chore: sync upstream

…efoundation#384) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* update autoware.proj.repos for scenario_simulator_v2 * Add `AAP_msgs:main` to dependency (for `scenario_simulator_v2`) Co-authored-by: yamacir-kit <httperror@404-notfound.jp>

KeisukeShima self-assigned this Feb 14, 2022

KeisukeShima force-pushed the fix/codecov-diff-coverage branch from 2c40891 to ef916f5 Compare February 14, 2022 10:02

KeisukeShima requested a review from kenji-miyake February 16, 2022 00:51

KeisukeShima marked this pull request as ready for review February 16, 2022 00:52

kenji-miyake marked this pull request as draft February 16, 2022 12:46

kenji-miyake marked this pull request as ready for review February 17, 2022 08:38

kenji-miyake reviewed Feb 17, 2022

View reviewed changes

.github/workflows/build-and-test-differential.yaml Outdated Show resolved Hide resolved

kenji-miyake reviewed Feb 17, 2022

View reviewed changes

.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved

kenji-miyake reviewed Feb 17, 2022

View reviewed changes

codecov.yaml Outdated Show resolved Hide resolved

KeisukeShima changed the base branch from tier4/proposal to main March 3, 2022 04:53

kenji-miyake reviewed Mar 8, 2022

View reviewed changes

codecov.yaml Outdated Show resolved Hide resolved

KeisukeShima assigned kenji-miyake and unassigned KeisukeShima Mar 14, 2022

kenji-miyake reviewed Mar 15, 2022

View reviewed changes

.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved

wep21 force-pushed the fix/codecov-diff-coverage branch from 5528151 to 1606b26 Compare March 20, 2022 10:43

ci(codecov): fix diff coverage

b82aac5

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>

KeisukeShima force-pushed the fix/codecov-diff-coverage branch from 1606b26 to b82aac5 Compare March 30, 2022 06:29

kenji-miyake reviewed Mar 30, 2022

View reviewed changes

Merge branch 'main' into fix/codecov-diff-coverage

881e2e2

kenji-miyake reviewed Apr 5, 2022

View reviewed changes

kenji-miyake assigned KeisukeShima and unassigned kenji-miyake Apr 5, 2022

Update codecov.yaml

efebdce

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

kenji-miyake approved these changes Apr 6, 2022

View reviewed changes

KeisukeShima merged commit 27d01da into autowarefoundation:main Apr 6, 2022

KeisukeShima deleted the fix/codecov-diff-coverage branch April 6, 2022 02:04

This was referenced Apr 6, 2022

chore: sync upstream tier4/autoware.universe#32

Merged

chore: sync upstream tier4/autoware.universe#33

Merged

This was referenced Apr 7, 2022

chore: sync files #648

Merged

chore: sync codecov.yaml autowarefoundation/autoware.core#22

Merged

kenji-miyake mentioned this pull request Jun 21, 2022

CodeCov does not show correct coverage diffs in PR comments #372

Closed

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

Merge pull request autowarefoundation#384 from tier4/feature/no_stopp…

469898c

…ing_area Feature/no stopping area

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

Merge pull request autowarefoundation#384 from tier4/feature/no_stopp…

7f9b7e4

…ing_area Feature/no stopping area Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

fix(planning_launch): replace lost count to lost time for avoidance (a…

9299af4

…utowarefoundation#384) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

soblin pushed a commit to soblin/autoware.universe that referenced this pull request May 10, 2023

Merge pull request autowarefoundation#384 from tier4/sync-upstream

8ea79b3

chore: sync upstream

keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023

fix(planning_launch): parameterize scale for lc safety check (autowar…

40685b5

…efoundation#384) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(codecov): fix diff coverage #384

ci(codecov): fix diff coverage #384

KeisukeShima commented Feb 14, 2022 •

edited by kenji-miyake

Loading

kenji-miyake commented Feb 16, 2022

KeisukeShima commented Mar 9, 2022 •

edited

Loading

kenji-miyake commented Mar 15, 2022

KeisukeShima commented Mar 15, 2022

KeisukeShima commented Mar 30, 2022

kenji-miyake commented Mar 30, 2022

kenji-miyake Mar 30, 2022

KeisukeShima Mar 31, 2022

kenji-miyake commented Mar 30, 2022

KeisukeShima commented Mar 31, 2022

kenji-miyake left a comment

kenji-miyake Apr 5, 2022

KeisukeShima Apr 6, 2022

KeisukeShima Apr 6, 2022

kenji-miyake Apr 6, 2022

kenji-miyake Apr 6, 2022

kenji-miyake Apr 6, 2022

KeisukeShima Apr 6, 2022

KeisukeShima Apr 6, 2022

kenji-miyake Apr 6, 2022 •

edited

Loading

KeisukeShima Apr 6, 2022

ci(codecov): fix diff coverage #384

ci(codecov): fix diff coverage #384

Conversation

KeisukeShima commented Feb 14, 2022 • edited by kenji-miyake Loading

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-Review Checklist for the PR Author

CI Checks

kenji-miyake commented Feb 16, 2022

KeisukeShima commented Mar 9, 2022 • edited Loading

kenji-miyake commented Mar 15, 2022

KeisukeShima commented Mar 15, 2022

KeisukeShima commented Mar 30, 2022

kenji-miyake commented Mar 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coverage section

comment section

flag_management section

kenji-miyake commented Mar 30, 2022

KeisukeShima commented Mar 31, 2022

kenji-miyake left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenji-miyake Apr 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

If there is no total flag

If the total flag is present

KeisukeShima commented Feb 14, 2022 •

edited by kenji-miyake

Loading

KeisukeShima commented Mar 9, 2022 •

edited

Loading

`coverage` section

`comment` section

`flag_management` section

kenji-miyake Apr 6, 2022 •

edited

Loading