Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz plugin #534

Merged
merged 6 commits into from
Mar 17, 2022
Merged

feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz plugin #534

merged 6 commits into from
Mar 17, 2022

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 17, 2022 •
edited
Loading

Related Issue(required)

Description(required)

Add interactive dummy pedestrian plugin tool that can be manipulated by using the mouse in order to simulate Ego's behavior in crosswalks more realistically and easily in Psim.

simplescreenrecorder-2022-03-17_14.06.10.mp4

Review Procedure(required)

please see the above video.

key commands are...

action key command
ADD Shift + Click Right Button
MOVE Hold down Right Button + Drug and Drop
DELETE Alt + Click Right Button

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@satoshi-ota
feat(tier4_perception_rviz_plugin): add mouse event util function
dc85a73 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota changed the title Feature/interactive pedestrian for rviz plugin feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz plugin Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #534 (133f3f7) into main (55a6a2b) will decrease coverage by 10.96%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #534       +/-   ##
==========================================
- Coverage   10.96%   0.00%   -10.97%     
==========================================
  Files         705       9      -696     
  Lines       49827     377    -49450     
  Branches     7128       0     -7128     
==========================================
- Hits         5462       0     -5462     
+ Misses      39979     377    -39602     
+ Partials     4386       0     -4386
Impacted Files Coverage Δ
...rception_rviz_plugin/src/tools/pedestrian_pose.cpp 0.00% <0.00%> (ø)
...rception_rviz_plugin/src/tools/pedestrian_pose.hpp 0.00% <0.00%> (ø)
...on/tier4_perception_rviz_plugin/src/tools/util.cpp 0.00% <0.00%> (ø)
control/trajectory_follower/src/mpc_utils.cpp
...locity_planner/src/scene_module/crosswalk/util.cpp
...dummy_infrastructure/dummy_infrastructure_node.hpp
...r4_planning_rviz_plugin/src/trajectory/display.cpp
.../src/concatenate_data/concatenate_data_nodelet.cpp
...ehavior_path_planner/path_shifter/path_shifter.hpp
... and 691 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a6a2b...133f3f7. Read the comment docs.

@satoshi-ota satoshi-ota marked this pull request as ready for review March 17, 2022 01:19
yukkysaito
yukkysaito reviewed Mar 17, 2022
View reviewed changes
common/tier4_perception_rviz_plugin/src/tools/interactive_pedestrian.cpp Outdated
@@ -0,0 +1,377 @@
// Copyright 2020 Tier IV, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2020 Tier IV, Inc.
// Copyright 2022 Tier IV, Inc.

@yukkysaito
Copy link
Contributor

yukkysaito commented Mar 17, 2022 •
edited
Loading

@satoshi-ota I think you can extend the existing pedestrian plugin. then the tool property has an interaction mode checkbox.

@satoshi-ota
Copy link
Contributor Author

@satoshi-ota I think you can extend the existing pedestrian plugin. then the tool property has an interaction mode checkbox.

Thank you for your advise 👍
Consider that ways to implement interactive dummy pedestrian by extending the existing plugins.

@satoshi-ota
feat(tier4_perception_rviz_plugin): delete option for QT
8f2773c 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp
824e977 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pede…
2d1d8f2 
…strian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feature/interactive-pedestrian-for-rviz-plugin branch from 4fd0771 to 2d1d8f2 Compare March 17, 2022 05:04
@satoshi-ota
fix(tier4_perception_rviz_plugin): change for void
0d2ccee 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsil…
133f3f7 
…on()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@isamu-takagi
Copy link
Contributor

LGTM, but it needs to be reviewed by others since I wrote the original code.

@yukkysaito yukkysaito self-requested a review March 17, 2022 15:56
yukkysaito
yukkysaito approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) March 17, 2022 22:40
@satoshi-ota satoshi-ota merged commit a67955d into autowarefoundation:main Mar 17, 2022
@satoshi-ota satoshi-ota deleted the feature/interactive-pedestrian-for-rviz-plugin branch March 17, 2022 22:45
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 18, 2022
Merged
k-obitsu pushed a commit to k-obitsu/autoware.universe that referenced this pull request Mar 19, 2022
@taikitanaka3 @mitsudome-r
@rej55 @k0suke-murakami @fred-apex-ai @cvasfi @sgermanserrano @nnmm @jilaada @esteve @wep21 @kenji-miyake @kmiya @TakaHoribe @yukkysaito @KeisukeShima @0x126 @h-ohta @tkimura4 @purewater0901 @takayuki5168 @kyoichi-sugahara @YoheiMishina @maxime-clem @niosus @kokosabu @1222-takeshi @pre-commit-ci
feat : add common math (autowarefoundation#26)
52b809b 
* release v0.4.0

* Add spline interpolation library (autowarefoundation#705)

* Feature/intersection use spline interpolation library (autowarefoundation#710)

* Use spline_interpolation module

* Remove debug messages

* Fix/spline interpolation in intersection module (autowarefoundation#726)

* Remove duplicating sample points

* Change isValidInput

* Apply clang-format

* Fix convergence check in PCG

* update osqp interface (autowarefoundation#730)

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add sample ros2 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 7127cf7.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port osqp-interface to ros2 (autowarefoundation#45)

It doesn't use any ros functionality so the source code is unchanged, only `package.xml` and `CMakeLists.txt` needed to
be modified. But osqp is added through a vendor package created at https://github.com/tier4/osqp_vendor

To test this locally, eigen needs to be installed in the environment with

    sudo apt install libeigen3-dev

* Port spline interpolation to ros2. (autowarefoundation#65)

* Fix osqp_interface dependencies (autowarefoundation#66)

* [osqp_interface] fix eigen3 dependencies

fixes autowarefoundation#63

* Fix link order in consumers of osqp_interface

* Update logger name for SOR class (autowarefoundation#87)

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* ROS2 Linting: osqp_interface (autowarefoundation#202)

* Add linters

* Fix clang-tidy missing header error

* ROS2 Linting: spline_interpolation (autowarefoundation#203)

* Add linters and fix indentation in package.xml

* Address PR comments:
 - Convert indents to spaces

* Use two spaces for indent

Co-authored-by: Esteve Fernandez <esteve@apache.org>

* Fix out-of-range bug of spline_interpolation (autowarefoundation#917) (autowarefoundation#273)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Ros2 v0.8.0 osqp interface (autowarefoundation#271)

* restore file name for v0.8.0 update

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typos in common modules (autowarefoundation#914)

* fix typos in common modules

* minor fix (lowercasing)

* revert changes in PathPoint.msg

* Fix/osqp interface api error (autowarefoundation#969)

* [osqp_interface] fix update setting api

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [osqp_interface] fix format

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name for v0.8.0 update"

This reverts commit b767c308d492c6f754f9aa45ab9521f209ad9c9c.

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Ros2 v0.8.0 ekf localizer (autowarefoundation#270)

* restore file name for v0.8.0 update

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix typos in localization (autowarefoundation#890)

* move kalman filter to lib package (autowarefoundation#1141)

* move kalman filter to lib package

* add kalman_filter dir

* Revert "restore file name for v0.8.0 update"

This reverts commit 485111da0aba91eeddda77e1e3b6b3f517373163.

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Feature/ekf tracker (autowarefoundation#1158) (autowarefoundation#381)

* Feature/ekf tracker (autowarefoundation#1158)

* change to ekf tracker

* visualize covariance

* cosmetic change

* cosmetic change

* change param

* add multi model ekf tracker (autowarefoundation#1165)

* add multi model ekf tracker

* cosmetic change

* cosmetic change

* add iou filter

* change correct license

* change correct license

* cosmetic change

* bug fix

* cosmetic change

* check clockwise

* change param

* bug fix

* cosmetic change

* add comment

* add enum

* cosmetic change

* cosmetic change

* apply format

* apply format

* fix config name

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [multi_object_tracker] apply ament_uncrustify

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [multi_object_tracker] fix lint errors

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix include brackets

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Fix typo in common module (autowarefoundation#433)

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Make control modules components (autowarefoundation#1262)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Make planning modules components (autowarefoundation#1263)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Porting small fix (autowarefoundation#1288)

* Delete unused code (autowarefoundation#1183)

* Fix control topic name of closest_velocity_checker.py (autowarefoundation#1174)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add comments for livox tag (autowarefoundation#1188)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Clear return value (autowarefoundation#1193)

* Change tracker model of unknown object (autowarefoundation#1204)

* treat polygon points as relative (autowarefoundation#1205)

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* hotfix: reference velocity in consideration of vehicle gear (autowarefoundation#1213)

* fix reference velocity for vehicle gear

* add initialization

* revert

* add comment

* change max area param (autowarefoundation#1218)

* Fix an identical code for different branches (autowarefoundation#1230)

* Update livox_tag_filter.launch.xml

* Fixup

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: shin <8327162+0x126@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix osqp interface double free problem (autowarefoundation#1327)

* Use smart pointers for members

* Add test code

* Fix typo

* Fix test code

* Change variable name

* Fix for lint test

* Fix include

* Fix header and CMakeLists.txt

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add new updater function to osqp_interface (autowarefoundation#1433) (autowarefoundation#1483)

* add new updater function

* modify spell

Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Fix bugprone-fold-init-type in spline_interpolation (autowarefoundation#1816)

* Fix bugprone-fold-init-type

* Fix modernize-use-override

* Fix cppcoreguidelines-pro-type-member-init

* Fix modernize-loop-convert

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* remove spline_interpolation, and create interpolation package that ha… (autowarefoundation#2114)

* remove spline_interpolation and add interpolation package

* fix bugs and add simple test

* modify application for interpolation package

* add some tests and fix ci test

* add some tests

* add -Werror

* move functions to anonymous

* fix reviews

* fix typo

* fix review and lint

* add tests

* resolve TODOs

* add README.md

* Update common/math/interpolation/test/src/test_interpolation_utils.cpp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update common/math/interpolation/test/src/test_interpolation_utils.cpp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update common/math/interpolation/test/src/test_interpolation_utils.cpp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix README.md

* dealt with reviews

* update README.md

* update README.md

* Update common/math/interpolation/README.md

* fix some bugs

* fix typo

* update README.md

* Update common/math/interpolation/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* fix test

* Update common/math/interpolation/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* fix cdots

* fix README.md

* Update common/math/interpolation/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Feature/lpf in common ros2 (autowarefoundation#1628)

* add first order lowpass filter (autowarefoundation#1505)

* add first order lowpass filter

* fix bugs, and add tests

* update copyright

* apply clang-format

* add another constructor

* add another reset member function

* update

* add test

* update test

* update test

* rename lowpass filter to signal processing

* Porting lpf1d to ros2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>

* [osqp interface] size check invalid argument error ros2 (autowarefoundation#1870)

* throw invalid_argument when osqp matrix/vector are invalid

* add test for invalid_argumetn

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove COLCON_IGNORE (autowarefoundation#506)

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>

* Remove COLCON_IGNORE from interpolation (autowarefoundation#516)

* delete COLCON IGNORE in signal processing package(autowarefoundation#537)

* Delet colcon ignore (autowarefoundation#534)

* Back port .auto control packages (autowarefoundation#571)

* Implement Lateral and Longitudinal Control Muxer

* [autowarefoundation#570] Porting wf_simulator

* [autowarefoundation#1189] Deactivate flaky test in 'trajectory_follower_nodes'

* [autowarefoundation#1189] Fix flacky test in 'trajectory_follower_nodes/latlon_muxer'

* [autowarefoundation#1057] Add osqp_interface package

* [autowarefoundation#1057] Add library code for MPC-based lateral control

* [autowarefoundation#1271] Use std::abs instead of abs

* [autowarefoundation#1057] Implement Lateral Controller for Cargo ODD

* [autowarefoundation#1246] Resolve "Test case names currently use snake_case but should be CamelCase"

* [autowarefoundation#1325] Deactivate flaky smoke test in 'trajectory_follower_nodes'

* [autowarefoundation#1058] Add library code of longitudinal controller

* Fix build error for trajectory follower

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix build error for trajectory follower nodes

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autowarefoundation#1272] Add AckermannControlCommand support to simple_planning_simulator

* [autowarefoundation#1058] Add Longitudinal Controller node

* [autowarefoundation#1058] Rename velocity_controller -> longitudinal_controller

* [autowarefoundation#1058] Update CMakeLists.txt for the longitudinal_controller_node

* [autowarefoundation#1058] Add smoke test python launch file

* [autowarefoundation#1058] Use LowPassFilter1d from trajectory_follower

* [autowarefoundation#1058] Use autoware_auto_msgs

* [autowarefoundation#1058] Changes for .auto (debug msg tmp fix, common func, tf listener)

* [autowarefoundation#1058] Remove unused parameters

* [autowarefoundation#1058] Fix ros test

* [autowarefoundation#1058] Rm default params from declare_parameters + use autoware types

* [autowarefoundation#1058] Use default param file to setup NodeOptions in the ros test

* [autowarefoundation#1058] Fix docstring

* [autowarefoundation#1058] Replace receiving a Twist with a VehicleKinematicState

* [autowarefoundation#1058] Change class variables format to m_ prefix

* [autowarefoundation#1058] Fix plugin name of LongitudinalController in CMakeLists.txt

* [autowarefoundation#1058] Fix copyright dates

* [autowarefoundation#1058] Reorder includes

* [autowarefoundation#1058] Add some tests (~89% coverage without disabling flaky tests)

* [autowarefoundation#1058] Add more tests (90+% coverage without disabling flaky tests)

* [autowarefoundation#1058] Use Float32MultiArrayDiagnostic message for debug and slope

* [autowarefoundation#1058] Calculate wheel_base value from vehicle parameters

* [autowarefoundation#1058] Cleanup redundant logger setting in tests

* [autowarefoundation#1058] Set ROS_DOMAIN_ID when running tests to prevent CI failures

* [autowarefoundation#1058] Remove TF listener and use published vehicle state instead

* [autowarefoundation#1058] Change smoke tests to use autoware_testing

* [autowarefoundation#1058] Add plotjuggler cfg for both lateral and longitudinal control

* [autowarefoundation#1058] Improve design documents

* [autowarefoundation#1058] Disable flaky test

* [autowarefoundation#1058] Properly transform vehicle state in longitudinal node

* [autowarefoundation#1058] Fix TF buffer of lateral controller

* [autowarefoundation#1058] Tuning of lateral controller for LGSVL

* [autowarefoundation#1058] Fix formating

* [autowarefoundation#1058] Fix /tf_static sub to be transient_local

* [autowarefoundation#1058] Fix yaw recalculation of reverse trajs in the lateral controller

* modify trajectory_follower for galactic build

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [autowarefoundation#1379] Update trajectory_follower

* [autowarefoundation#1379] Update simple_planning_simulator

* [autowarefoundation#1379] Update trajectory_follower_nodes

* apply trajectory msg modification in control

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* move directory

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remote control/trajectory_follower level dorectpry

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove .iv trajectory follower

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use .auto trajectory_follower

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove .iv simple_planning_simulator & osqp_interface

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use .iv simple_planning_simulator & osqp_interface

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add tmp_autoware_auto_dependencies

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* tmporally add autoware_auto_msgs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* apply .auto message split

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix build depend

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix packages using osqp

* fix autoware_auto_geometry

* ignore lint of some packages

* ignore ament_lint of some packages

* ignore lint/pre-commit of trajectory_follower_nodes

* disable unit tests of some packages

Co-authored-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Joshua Whitley <josh.whitley@autoware.org>
Co-authored-by: Igor Bogoslavskyi <igor.bogoslavskyi@gmail.com>
Co-authored-by: MIURA Yasuyuki <kokosabu@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add readme signal processing (autowarefoundation#587)

* add readme signal processing

* better fix

* add readme in kalman_filter (autowarefoundation#633)

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Yunus Emre Çalışkan <yunus.ec@gmail.com>
Co-authored-by: Servando <43142004+sgermanserrano@users.noreply.github.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: shin <8327162+0x126@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com>
Co-authored-by: Yohei Mishina <66298900+YoheiMishina@users.noreply.github.com>
Co-authored-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Joshua Whitley <josh.whitley@autoware.org>
Co-authored-by: Igor Bogoslavskyi <igor.bogoslavskyi@gmail.com>
Co-authored-by: MIURA Yasuyuki <kokosabu@gmail.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Apr 24, 2022
@satoshi-ota
feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz p…
52e6524 
…lugin (autowarefoundation#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request May 31, 2022
@satoshi-ota
feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz p…
7f7d065 
…lugin (autowarefoundation#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Jun 20, 2022
@satoshi-ota @kosuke55
feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz p…
6055697 
…lugin (#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Jun 27, 2022
@satoshi-ota @taikitanaka3
feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz p…
5b75dda 
…lugin (#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Jun 27, 2022
@satoshi-ota @taikitanaka3
feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz p…
0b7043a 
…lugin (#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4 referenced this pull request in tier4/autoware.universe Jun 27, 2022
@taikitanaka3 @satoshi-ota
@1222-takeshi @wep21 @pre-commit-ci
feat: perception rviz plugins (#74)
16edd36 
* feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz plugin (#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): plugin supports interactive manipulation for dummy CAR & UNKNOWN object (#554)

* fix(tier4_perception_rviz_plugin): split pedestrian.hpp(cpp) into two parts

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): modify logic of velocity & pose calculation

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): plugin supports 2D Interactive dummy car

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): plugin supports 2D Interactive unknown object

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(tier4_perception_rviz_plugin): use common class

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): fix dummy pedestrian shape (#571)

* fix(tier4_perception_rviz_plugin): set interactive object velocity to zero on releasing the object (#686)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): modify build error in rolling (#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* feat(perception_rviz_plugin): add 2d dummy bus with height (#903)

* feat(perception_rviz_plugin): add 2d dummy bus with height

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@satoshi-ota @boyali
feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz p…
45e48db 
…lugin (tier4#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@satoshi-ota @boyali
feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz p…
a1e48ad 
…lugin (tier4#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@satoshi-ota @boyali
feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz p…
e609b5b 
…lugin (tier4#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
@kenji-miyake
ci(sync-files): sync PR templates (#534)
5e2463d 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isamu-takagi isamu-takagi isamu-takagi left review comments

@yukkysaito yukkysaito yukkysaito approved these changes

@0x126 0x126 Awaiting requested review from 0x126

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@satoshi-ota @yukkysaito @isamu-takagi