Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagnostic_graph_aggregator): rename system_diagnostic_graph package #5827

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Dec 11, 2023

Description

Rename system_diagnostic_graph to diagnostic_graph_aggregator.

Tests performed

Check build success and colcon test.

colcon test --packages-select diagnostic_graph_aggregator

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…kage

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Dec 11, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Dec 11, 2023
@isamu-takagi isamu-takagi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (281f1ec) 15.28% compared to head (d3d243f) 15.41%.
Report is 30 commits behind head on main.

Files Patch % Lines
...iagnostic_graph_aggregator/src/node/aggregator.cpp 0.00% 1 Missing ⚠️
...diagnostic_graph_aggregator/src/node/converter.cpp 0.00% 1 Missing ⚠️
...stem/diagnostic_graph_aggregator/src/tool/tool.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5827      +/-   ##
==========================================
+ Coverage   15.28%   15.41%   +0.12%     
==========================================
  Files        1739     1753      +14     
  Lines      119751   120388     +637     
  Branches    36365    36614     +249     
==========================================
+ Hits        18304    18557     +253     
- Misses      80972    81199     +227     
- Partials    20475    20632     +157     
Flag Coverage Δ *Carryforward flag
differential 39.71% <0.00%> (?)
total 15.28% <ø> (ø) Carriedforward from 281f1ec

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi enabled auto-merge (squash) December 14, 2023 06:51
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 4fc8a4e into autowarefoundation:main Dec 14, 2023
36 of 38 checks passed
@isamu-takagi isamu-takagi deleted the feat/move-system-diagnostic-graph branch December 14, 2023 07:16
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…kage (autowarefoundation#5827)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…kage (autowarefoundation#5827)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
isamu-takagi added a commit to tier4/autoware.universe that referenced this pull request Dec 19, 2023
…kage (autowarefoundation#5827)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants