-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diagnostic_graph_aggregator): rename system_diagnostic_graph package #5827
feat(diagnostic_graph_aggregator): rename system_diagnostic_graph package #5827
Conversation
…kage Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5827 +/- ##
==========================================
+ Coverage 15.28% 15.41% +0.12%
==========================================
Files 1739 1753 +14
Lines 119751 120388 +637
Branches 36365 36614 +249
==========================================
+ Hits 18304 18557 +253
- Misses 80972 81199 +227
- Partials 20475 20632 +157
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…kage (autowarefoundation#5827) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…kage (autowarefoundation#5827) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
…kage (autowarefoundation#5827) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
…kage (autowarefoundation#5827) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…kage (autowarefoundation#5827) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…kage (autowarefoundation#5827) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…kage (autowarefoundation#5827) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Description
Rename
system_diagnostic_graph
todiagnostic_graph_aggregator
.Tests performed
Check build success and colcon test.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.