Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): use nvidia/cuda image as cuda_base_image #4035

Closed
wants to merge 4 commits into from
Closed

chore(docker): use nvidia/cuda image as cuda_base_image #4035

wants to merge 4 commits into from

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Dec 5, 2023 •
edited
Loading

Description

TBD

Related links

Tests performed

TBD

Notes for reviewers

TBD

Interface changes

N/A

Effects on system behavior

This pull-request effects only on build tests.

docker image size

before

ghcr.io/autowarefoundation/autoware-universe-old   humble-latest-cuda            b82b6ff225cc   15 minutes ago   20.8GB

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@HansRobo
feat(docker): use nvidia/cuda image as cuda_base_image
b5df068 
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@HansRobo
chore(docker): stop installing nvidia packages in docker image
67ba0ee 
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@HansRobo
chore(docker): disable cuda install on nvidia/cuda images
74dcacd 
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@HansRobo
Merge branch 'main' into use-nvidia-image
0f3a5b0
@xmfcx
Copy link
Contributor

xmfcx commented Dec 11, 2023

Related:

cc. @oguzkaganozt

@xmfcx xmfcx added type:ci Continuous Integration (CI) processes and testing. type:containers Docker containers, containerization of components, or container orchestration. labels Dec 11, 2023
@oguzkaganozt
Copy link
Contributor

This is now obsolete, with this merged: #4072.

@HansRobo HansRobo deleted the use-nvidia-image branch March 8, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt will be requested when the pull request is marked ready for review oguzkaganozt is a code owner

@youtalk youtalk Awaiting requested review from youtalk youtalk will be requested when the pull request is marked ready for review youtalk is a code owner

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r will be requested when the pull request is marked ready for review mitsudome-r is a code owner

Assignees

@HansRobo HansRobo

Labels
type:ci Continuous Integration (CI) processes and testing. type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HansRobo @xmfcx @oguzkaganozt