fix(docker): fix the src directory in docker/build.sh
#4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
requested review from
oguzkaganozt,
mitsudome-r and
xmfcx
as code owners
mitsudome-r
approved these changes
Jun 20, 2024
|
I think we should also fix the path for deleting the cloned Line 145 in ce3e912 That being said, should we remove the src directory? If we are also assuming users building docker from their customized code under Line 144 in ce3e912 |
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
|
@mitsudome-r I removed |
pravinkmr26
pushed a commit
to pravinkmr26/autoware
that referenced
this pull request
Jul 15, 2024
…undation#4894) Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4849 (comment) issue by @isouf mentioned.
This PR correctly fixes the location of the
srcdirectory.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.