Skip to content

Conversation

felipemadero
Copy link
Contributor

@felipemadero felipemadero commented Sep 25, 2025

Why this should be merged

  • The previous ledger dependency no longer works with Avalanche Ledger app v1.3.7; adopting v1.1.0 restores support for current Ledger firmware.
  • Upstream has moved the Go package into its own repository (github.com/ava-labs/ledger-avalanche-go)

How this works

  • Updates utils/crypto/ledger/ledger.go to import the module from the new standalone repository.
  • Refreshes go.mod/go.sum so the project depends on ledger-avalanche-go v1.1.0

How this was tested

  • Using a CLI version compiled with the new avalanchego dep, and Ledger Nano S+, to complete a full L1 creation flow on fuji

Need to be documented in RELEASES.md?

@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 19:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Avalanche ledger dependencies from an outdated version to v1.1.0 to restore compatibility with current Ledger firmware (v1.3.7). The main change involves migrating from the legacy ledger-avalanche/go repository to the new standalone ledger-avalanche-go repository.

  • Updates the ledger import path to use the new standalone repository
  • Updates go.mod to use ledger-avalanche-go v1.1.0
  • Includes various transitive dependency updates as part of the module refresh

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
utils/crypto/ledger/ledger.go Updates import path from legacy to new standalone ledger repository
go.mod Updates primary ledger dependency to v1.1.0 and refreshes all transitive dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

felipemadero and others added 2 commits September 25, 2025 16:58
Changes the test case from using numeric value 1234 to an empty object {}
to properly trigger the "failed to cast to bool" error in the test chain.
This fixes the TestStateSyncEnabledFromEnvVars/invalid_state_sync_value test.
@StephenButtolph StephenButtolph moved this to In Review 🔎 in avalanchego Oct 1, 2025
@joshua-kim joshua-kim moved this from In Review 🔎 to In Progress 🏗️ in avalanchego Oct 1, 2025
felipemadero and others added 2 commits October 1, 2025 14:33
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: felipemadero <felipe.madero@gmail.com>
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 1, 2025
Merged via the queue into master with commit cdd222f Oct 1, 2025
35 checks passed
@StephenButtolph StephenButtolph deleted the update-ledger-library-v1.1.0-new branch October 1, 2025 18:07
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done 🎉 in avalanchego Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants