Skip to content

@Ignore should not be included in openapi generation #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

@Ignore should not be included in openapi generation #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions http-generator-core/src/main/java/io/avaje/http/generator/core/ElementReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
import java.util.Optional;
import java.util.Set;

import javax.lang.model.element.Element;
import javax.lang.model.element.ElementKind;
import javax.lang.model.element.TypeElement;
import javax.lang.model.element.*;

import io.avaje.http.generator.core.openapi.MethodDocBuilder;
import io.avaje.http.generator.core.openapi.MethodParamDocBuilder;
Expand Down Expand Up @@ -252,8 +250,19 @@ void writeParamName(Append writer) {
*/
void buildApiDocumentation(MethodDocBuilder methodDoc) {
if (!isPlatformContext() && !isParamMap && paramType != ParamType.BEANPARAM) {
new MethodParamDocBuilder(methodDoc, this).build();
if (includeParam()) {
new MethodParamDocBuilder(methodDoc, this).build();
}
}
}

private boolean includeParam() {
for (AnnotationMirror annotationMirror : element.getAnnotationMirrors()) {
if ("io.avaje.http.api.Ignore".equals(annotationMirror.getAnnotationType().toString())) {
return false;
}
}
return true;
}

void writeValidate(Append writer) {
Expand Down
6 changes: 3 additions & 3 deletions ...-generator-core/src/main/java/io/avaje/http/generator/core/openapi/OpenAPISerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,10 @@ static Object extractPrimitiveValue(Object object) {
* @throws IllegalAccessException if the fields of the value object cannot be accessed
*/
static void write(StringBuilder sb, Object value) throws IllegalAccessException {
final var isprimitiveWrapper = isPrimitiveWrapperType(value);
final var isPrimitiveWrapper = isPrimitiveWrapperType(value);
// Append primitive or string value as is
if (value.getClass().isPrimitive() || value instanceof String || isprimitiveWrapper) {
if (isprimitiveWrapper) {
if (value.getClass().isPrimitive() || value instanceof String || isPrimitiveWrapper) {
if (isPrimitiveWrapper) {
sb.append(extractPrimitiveValue(value));
} else {
sb.append("\"");
Expand Down
1 change: 0 additions & 1 deletion http-generator-core/src/main/java/io/avaje/http/generator/core/openapi/SchemaDocBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import javax.lang.model.util.Types;

import io.avaje.http.generator.core.HiddenPrism;
import io.avaje.http.generator.core.UType;
import io.avaje.http.generator.core.Util;
import io.avaje.prism.GeneratePrism;
import io.swagger.v3.oas.models.Operation;
Expand Down