Skip to content

2.4.2: certificate values acme.sh could run

Latest

Choose a tag to compare

@avandeputte avandeputte released this 22 Nov 01:34
2de1f0b

2.4.2: certificate values acme.sh could run

acme.sh keeps the ACME account's e-mail address, a challenge type's DNS API hook name and a certificate's domain names in files that it later runs as shell code, as root. A quote in one of them could run a command:

  • Account e-mail: on the next issue or renewal.
  • DNS API hook: the next time someone ran acme.sh --list, --renew or --cron by hand.
  • Domain names: acme.sh refused quotes itself, but a name like ../../x made it write outside its own folder.

Only someone who can already change the configuration could set these values. 2.4.2 refuses them when they are saved, in the editors and in the certificate wizard, and checks them again before acme.sh runs, for a configuration that came by cluster sync, a restored backup or an older version.

  • A DNS API hook is letters, digits and _, such as dns_cf. Every hook acme.sh ships fits.
  • An e-mail address is letters, digits and . _ % + = - before the @, a domain after it.
  • A domain name is labels of letters, digits, - and _, optionally starting with *., or an IPv6 address.

A value stored before 2.4.2 that does not fit makes that certificate fail with the reason, instead of being issued. Ordinary values are unaffected. Found from #41.