Skip to content

GST Calculator #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 27, 2021
Merged

GST Calculator #985

merged 5 commits into from
May 27, 2021

Conversation

Amit366
Copy link
Contributor

@Amit366 Amit366 commented Apr 28, 2021 •
edited by kaustubhgupta
Loading

Description

Added script GST calculation

Fixes #976

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • I have added the project meta data in the PR template.
  • I have created the requirements.txt file if needed.

Project Metadata

If there is no-file/nothing to fill the below fields with, then type: none

Example: If no requirements.txt needed/present, then type none in Requirments.

Category:

  • Calculators
  • AI/ML
  • Scrappers
  • Social_Media
  • PDF
  • Image_Processing
  • Video_Processing
  • Games
  • Networking
  • OS_Utilities
  • Automation
  • Cryptography
  • Computer_Vision
  • Fun
  • Others

Title: GST calculator

Folder: GST calculator

Requirements: none

Script: script.py

Arguments: none

Contributor: Amit366

Description: A GST calculator.

kaustubhgupta
kaustubhgupta suggested changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I click find button one more time, the old result is still present, fix this:

image

@kaustubhgupta kaustubhgupta added the bug Something isn't working label Apr 28, 2021
@Amit366
Copy link
Contributor Author

Amit366 commented Apr 28, 2021

@kaustubhgupta after every iteration click on clear

@Amit366
Copy link
Contributor Author

Amit366 commented Apr 28, 2021

Then it will be fine

@kaustubhgupta
Copy link
Contributor

@kaustubhgupta after every iteration click on clear

I know the functioning of the CLEAR button. Every time you press find, it should not display the results in a continuous manner where previous results are still there but it should clear the previous text and then display a new one. CLEAR Button is to clear every field in the application.

@Amit366
Copy link
Contributor Author

Amit366 commented Apr 28, 2021

@kaustubhgupta please check now.

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels Apr 29, 2021
Kushal997-das
Kushal997-das approved these changes Apr 30, 2021
View reviewed changes
Copy link

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kaustubhgupta kaustubhgupta requested review from antrikshmisri and removed request for antrikshmisri May 1, 2021 03:32
@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work and removed next review needed Approved by some mentors, more approvals needed labels May 1, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

Due to inactivity this pull request has been marked as stale.

@github-actions github-actions bot added the Stale PRs with no updates label May 9, 2021
@kaustubhgupta kaustubhgupta removed the Stale PRs with no updates label May 9, 2021
kaustubhgupta
kaustubhgupta suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amit366 Add the requirements.txt file and update the PR template with project metadata. Look at this PR for reference: #1002

@kaustubhgupta kaustubhgupta removed the Approved PR Approved and Ready to Merge label May 11, 2021
@kaustubhgupta kaustubhgupta added the hold Needs a second thought label May 11, 2021
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge and removed hold Needs a second thought labels May 12, 2021
@github-actions
Copy link

Due to inactivity this pull request has been marked as stale.

@github-actions github-actions bot added the Stale PRs with no updates label May 20, 2021
@kaustubhgupta kaustubhgupta removed the Stale PRs with no updates label May 20, 2021
@github-actions
Copy link

Due to inactivity this pull request has been marked as stale.

@github-actions github-actions bot added the Stale PRs with no updates label May 27, 2021
@kaustubhgupta kaustubhgupta added manual-db-update-req The PR was merged but db was not updated. Need to update the database manully and removed Stale PRs with no updates labels May 27, 2021
@kaustubhgupta kaustubhgupta merged commit a86f418 into avinashkranjan:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
4 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

@Kushal997-das Kushal997-das Kushal997-das approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work manual-db-update-req The PR was merged but db was not updated. Need to update the database manully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GST Claculator
5 participants
@Amit366 @kaustubhgupta @antrikshmisri @santushtisharma10 @Kushal997-das