Skip to content

Write Dockerfile CSV and Markdown on no vulns #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Write Dockerfile CSV and Markdown on no vulns #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions entrypoint/entrypoint/dockerfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,6 @@ def dockerfile_vulns_to_csv(dockerfile_vulns):

def write_dockerfile_report_csv(inspector_scan_path, dst_file):
dockerfile_vulns = get_dockerfile_vulns(inspector_scan_path)
if len(dockerfile_vulns) == 0:
logging.info(f"skipping dockerfile vulnerability CSV report because no vulnerabilities were detected")
return False

csv_output = dockerfile_vulns_to_csv(dockerfile_vulns)

Expand All @@ -328,9 +325,6 @@ def write_dockerfile_report_csv(inspector_scan_path, dst_file):

def write_dockerfile_report_md(inspector_scan_path, dst_file):
dockerfile_vulns = get_dockerfile_vulns(inspector_scan_path)
if len(dockerfile_vulns) == 0:
logging.info(f"skipping dockerfile vulnerability MD report because no vulnerabilities were detected")
return False

markdown_report = get_markdown_header()
for vuln in dockerfile_vulns:
Expand Down
4 changes: 2 additions & 2 deletions entrypoint/tests/test_dockerfile_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def test_write_dockerfile_report_csv(self):
write_counter += 1
os.remove(dst)

expected_writes = 2
expected_writes = 4
self.assertEqual(expected_writes, write_counter)

def test_write_dockerfile_report_md(self):
Expand All @@ -170,7 +170,7 @@ def test_write_dockerfile_report_md(self):
write_counter += 1
os.remove(dst)

expected_writes = 2
expected_writes = 4
self.assertEqual(expected_writes, write_counter)


Expand Down