Gen2 storage #13262
Closed
Gen2 storage #13262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating type info * update downloadData implementation * fix output type * path dynamic construction * resolve merge conflit * add unit tests for path * update bundle size * update deprecation warning * update test * misc changes * address comments
* update deprecation warning per product * include integ test path
* fix: extract isInputWithPath into separate file * chore: add unit test * Update packages/storage/__tests__/providers/s3/apis/utils/isInputWithPath.test.ts Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com> * Update packages/storage/__tests__/providers/s3/apis/utils/isInputWithPath.test.ts * address feedback --------- Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com> Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com>
* add prefix resolver deprecation warning * add input validation on path parameter
… sync-gen2Storage-with-main
Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>
* update validation * add gen2 integ test
* feat(storage): add path supp to copy API * address feedback * address feedback * update copy tests with leading / * address feedback * increase bundle size --------- Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>
* update validation on path assertion --------- Co-authored-by: Ashwin Kumar <ashwinkumar2468@gmail.com>
* feat: add gen2 path to getProperties API * test: add unit tests for path parameter * nit: remove unnecessary colon * feat: add path to types * test: first pass to add path coverage * fix: adjust tests * chore: remove links from tsdocs * test: fix expected Key * chore: prettier fix * chore: increase getUrl bundle size * chore: clean up tsdocs in getProperties * chore: consolidate constants imports * test: remove leading slash from path * chore: address feedback * chore: fix test and bundle size check * chore: add back-tics to tsdocs * chore: use test.each instead of forEach * chore: fix deprecation and tsdocs * chore: add contextSpec to copy tsdocs * Update packages/storage/src/providers/s3/apis/copy.ts Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com> * chore: another tsdoc fix * chore: add tsdocs to server getUrl * address feedback * address feedback * address feedback * chore: add overload for deprecation messaging to getUrl * address feedback --------- Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com>
* fix(storage): refactor copy API types * fix(storage): refactor remove API types * fix(storage): refactor getUrl API types * fix(storage): refactor getProperties API types * fix(storage): refactor list API types * fix(storage): refactor download API types * fix(storage): refactor upload API types * verify all - update missed StorageOperationInputPrefix type * revert StorageOperationInputWithType type --------- Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>
* update overload type to include union * update type name and cleanup * update server api overload types * update bundle size * update type to use strict union input
Config: relax types to fix issues with TypeScript
* update getProperties return type * update remove return type * update downloadData return types * update copy return types * update upload return types * update list return types * clean up output types * update test and list api
|
Please ensure that this PR:
A repository administrator is required to review & merge this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.