chore: enable retry for e2e tests #14519
Conversation
| yarn && break | ||
| echo "Attempt $i failed." | ||
| sleep 5 | ||
| done |
There was a problem hiding this comment.
do we have issues, where installing project dependencies fails or times out? and a reinstall fixes it?
There was a problem hiding this comment.
Yes, we occasionally have 5xx during install. See https://github.com/aws-amplify/amplify-js/actions/runs/17037734366/job/48294300286
| sample_name: [mfa] | ||
| spec: refresh-token-auth | ||
| retry_count: 15 | ||
| timeout_minutes: 90 |
There was a problem hiding this comment.
Do we know how that interacts with https://github.com/aws-amplify/amplify-js-samples-staging/pull/1091/files?
There was a problem hiding this comment.
In GitHub Actions, the timeout-minutes setting defines the maximum number of minutes a job or a step is allowed to run before GitHub automatically cancels it. That includes multiple times of retries within the step.
While the timeout in https://github.com/aws-amplify/amplify-js-samples-staging/pull/1091/files should be the timeout when running individual test.
There was a problem hiding this comment.
The timeout from my PR is for Cypress commands. The timeout here is for the whole E2E test as defined in the workflow file.
Description of changes
Enable retries for e2e tests, as well as yarn install step for sample staging repo, which fails occasionally.
Issue #, if available
Description of how you validated changes
Run e2e tests with the updated github workflow: https://github.com/aws-amplify/amplify-js/actions/runs/17043975986
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.