chore: enable retry for e2e tests #14519
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -629,13 +629,15 @@ tests: | |
| category: auth | ||
| sample_name: [custom-auth] | ||
| spec: custom-auth | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| - test_name: integ_next_auth_sign_in_with_sms_mfa | ||
| desc: 'Resumable sign in with SMS MFA flow' | ||
| framework: next | ||
| category: auth | ||
| sample_name: [mfa] | ||
| spec: sign-in-resumable-mfa | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: resum-signin | ||
|
|
@@ -844,20 +846,23 @@ tests: | |
| category: storage | ||
| sample_name: [storage-gen2] | ||
| spec: storage-gen2 | ||
| retry_count: 10 | ||
| browser: *minimal_browser_list | ||
| - test_name: integ_react_storage_internal | ||
| desc: 'React Storage Gen2 Internal APIs' | ||
| framework: react | ||
| category: storage | ||
| sample_name: [storage-gen2-internal] | ||
| spec: storage-gen2-internal | ||
| retry_count: 10 | ||
| browser: *minimal_browser_list | ||
| - test_name: integ_next_storage | ||
| desc: 'Next Storage Auth' | ||
| framework: next | ||
| category: storage | ||
| sample_name: [storage-auth] | ||
| spec: storage-client-server | ||
| retry_count: 10 | ||
| browser: [chrome] # firefox issues with secure cookies in cypress, manual testing works fine | ||
|
|
||
| # INAPPMESSAGING | ||
|
|
@@ -920,6 +925,7 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: mfa-req-email | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: mfa-req-email | ||
|
|
@@ -929,6 +935,7 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: mfa-req-phone | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: mfa-req-phone | ||
|
|
@@ -938,6 +945,7 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: mfa-opt-email | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: mfa-opt-email | ||
|
|
@@ -947,6 +955,7 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: mfa-opt-phone | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: mfa-opt-phone | ||
|
|
@@ -956,6 +965,7 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: mfa-setup | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: mfa-setup | ||
|
|
@@ -965,6 +975,7 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: passwordless/auto-sign-in | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: pwl-autosignin | ||
|
|
@@ -992,6 +1003,7 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: passwordless/sign-up | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: pwl-signup | ||
|
|
@@ -1001,6 +1013,7 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: passwordless/miscellaneous | ||
| retry_count: 15 | ||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: pwl-misc | ||
|
|
@@ -1021,6 +1034,8 @@ tests: | |
| category: auth | ||
| sample_name: [mfa] | ||
| spec: refresh-token-auth | ||
| retry_count: 15 | ||
| timeout_minutes: 90 | ||
|
There was a problem hiding this comment. Do we know how that interacts with https://github.com/aws-amplify/amplify-js-samples-staging/pull/1091/files? There was a problem hiding this comment. In GitHub Actions, the timeout-minutes setting defines the maximum number of minutes a job or a step is allowed to run before GitHub automatically cancels it. That includes multiple times of retries within the step. While the timeout in https://github.com/aws-amplify/amplify-js-samples-staging/pull/1091/files should be the timeout when running individual test. There was a problem hiding this comment. The timeout from my PR is for Cypress commands. The timeout here is for the whole E2E test as defined in the workflow file. |
||
| browser: *minimal_browser_list | ||
| env: | ||
| NEXT_PUBLIC_BACKEND_CONFIG: misc-tokenref | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have issues, where installing project dependencies fails or times out? and a reinstall fixes it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we occasionally have 5xx during install. See https://github.com/aws-amplify/amplify-js/actions/runs/17037734366/job/48294300286