-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add iOS library latest-legacy toggle switch #4567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like /lib/[x]
files are being replaced with /lib-v1
files -- are redirects in place? on iOS all of the paths should still work (but access a v2 page), but on Android links going to /lib
pages will be broken until we add them.
Android docs are still available under |
@phantumcode - can you please elaborate on why this toggle is needed?
|
Amplify iOS V2 introduces major breaking changes. All public APIs in each categories will be different syntax. It's functionally the same as V1 but introduces Swift's new async/await structured concurrency pattern. In order to migrate from V1 to V2, customers will need to update the API usages and update the iOS app to adopt the new Swift async/await structured concurrency. |
Does it make sense to swap the positions of
I see there's precedent for the way you have it here, but it feels wrong to have reverse chronological for LTR languages here. |
This pull request introduces 1 alert when merging f9c943a into 2492477 - view on LGTM.com new alerts:
|
Good suggestion @atierian . @hdworld11 is also in agreement. I've updated the latest revision to re-order the toggle switches with v2 selected by default. |
* add iOS library latest-legacy toggle switch * update verbige from Legacy to v1 * remove v1 postfix on category titles * fix filter check * swap the order of v1-v2 toggle * fix lint rule violation
* add iOS library latest-legacy toggle switch * update verbige from Legacy to v1 * remove v1 postfix on category titles * fix filter check * swap the order of v1-v2 toggle * fix lint rule violation
Issue #, if available:
Description of changes:
Screenshot:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.