Skip to content

Conversation

nearestnabors
Copy link
Contributor

Our Ionic content gets very little traffic, and we lack the deep expertise to keep them up to date regularly. Rather than risk greeting learners with out of date content, we'd like to retire the Ionic tutorial and refocus our efforts on the remaining platforms we've committed to.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nearestnabors nearestnabors requested review from a team as code owners October 8, 2022 02:56
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

salihgueler
salihgueler previously approved these changes Oct 10, 2022
timngyn
timngyn previously approved these changes Oct 12, 2022
Copy link
Contributor

@timngyn timngyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested on staging site and didn't run into any issues

jacoblogan
jacoblogan previously approved these changes Oct 20, 2022
Copy link
Contributor

@katieklein katieklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachelnabors, just wanted to note a merge conflict in src/fragments/start/getting-started/ionic/setup.mdx

wrpeck and others added 19 commits October 20, 2022 20:53
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Thomas Leing <leint@amazon.com>
* fix: ignore queries while switching platform

* fix: nextjs build failed with global object 'window'
* clarifying this needs a new terminal

* updates

* Update src/fragments/start/getting-started/common/prereq.mdx

Co-authored-by: siegerts <stephen.siegert@gmail.com>

* Update src/fragments/start/getting-started/react/api.mdx

Co-authored-by: siegerts <stephen.siegert@gmail.com>

* updating per review

Co-authored-by: siegerts <stephen.siegert@gmail.com>
* Fixed type for Auth.federatedSignIn() in lib/auth/js/social

* Fix facebook oauth setup steps
…s with example (#4476)

* fix: add section to clarify steps to update Cognito user email address with example

Related to:
aws-amplify/amplify-js#987
aws-amplify/amplify-cli#10773

* remove extra space
* small updates to getting started guide

* clarified the inspector panel location

* Expo CLI wording update

* remove react-native-picker and react-native package

* update to RN getting started guide

* updated installation of React Native CLI

* update setup steps

* removed broken closing tags

* fixed tag

* removed open tag without closing tag

* added closing tag
@nearestnabors nearestnabors requested review from a team as code owners October 21, 2022 03:56
@nearestnabors
Copy link
Contributor Author

nearestnabors commented Oct 21, 2022

@katiegoines Sorry, I'm trying my best to resolve the conflict, but it's not working out. Mind taking a look on your end?

Edit: nevermind, I got it

Copy link
Contributor

@timngyn timngyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.