React native getting started guide updates #4714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintannp
reviewed
Oct 18, 2022
chintannp
reviewed
Oct 18, 2022
chintannp
reviewed
Oct 18, 2022
cshfang
reviewed
Oct 19, 2022
nearestnabors
suggested changes
Oct 20, 2022
nearestnabors
approved these changes
Oct 20, 2022
timngyn
suggested changes
Oct 20, 2022
| npx amplify-app@latest | ||
| ``` | ||
|
|
||
| </Block> |
There was a problem hiding this comment.
Is this a typo? I think this is causing the build to fail because there isn't an opening <Block> statement. We could remove it if that's okay with you
There was a problem hiding this comment.
@timngyn - please do! I think it is a typo for sure
There was a problem hiding this comment.
I've had a look, and it seems like there's an open tag without a closing tag as well. @abdallahshaban557, mind having a look? I want to make sure we aren't scrobbling this up
There was a problem hiding this comment.
That one can also be removed - I'll submit an update shortly
There was a problem hiding this comment.
Updated now
nearestnabors
suggested changes
Oct 20, 2022
| npx amplify-app@latest | ||
| ``` | ||
|
|
||
| </Block> |
There was a problem hiding this comment.
I've had a look, and it seems like there's an open tag without a closing tag as well. @abdallahshaban557, mind having a look? I want to make sure we aren't scrobbling this up
timngyn
approved these changes
Oct 20, 2022
nearestnabors
approved these changes
Oct 21, 2022
nearestnabors
pushed a commit
that referenced
this pull request
Oct 21, 2022
* small updates to getting started guide * clarified the inspector panel location * Expo CLI wording update * remove react-native-picker and react-native package * update to RN getting started guide * updated installation of React Native CLI * update setup steps * removed broken closing tags * fixed tag * removed open tag without closing tag * added closing tag
nearestnabors
pushed a commit
that referenced
this pull request
Oct 21, 2022
* removes ionic * scours away ionic files * Remove typo * reverting yarn upgrade. we need to update the yarn lock * Fixed type for Auth.federatedSignIn() in lib/auth/js/social (#4699) * Fix lib-v1 error where refresh on root gave 404 (#4722) Co-authored-by: Thomas Leing <leint@amazon.com> * fix: edits to next.js getting started to bring it current (#4672) * fix: edits to next.js getting started to bring it current * updates to next.js hosting content * Removing Responsive Components from directory * Updating responsive documentation * improved docs for responsive components * Updating responsive documentation * merging * Adding link to theme * minor fix * another minor fix * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update src/pages/console/uibuilder/responsive.mdx Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> * Update cspell.json * requested edits to documentation * Update cspell.json * Add Android dev-preview files back (#4727) Co-authored-by: Thomas Leing <leint@amazon.com> * Update versions.ts * fix: ignore queries while switching platform (#4730) * fix: ignore queries while switching platform * fix: nextjs build failed with global object 'window' * Getting Started Tutorial : React update (#4676) * clarifying this needs a new terminal * updates * Update src/fragments/start/getting-started/common/prereq.mdx Co-authored-by: siegerts <stephen.siegert@gmail.com> * Update src/fragments/start/getting-started/react/api.mdx Co-authored-by: siegerts <stephen.siegert@gmail.com> * updating per review Co-authored-by: siegerts <stephen.siegert@gmail.com> * Facebook OAuth steps update (#4731) * Fixed type for Auth.federatedSignIn() in lib/auth/js/social * Fix facebook oauth setup steps * fix: add section to clarify steps to update Cognito user email address with example (#4476) * fix: add section to clarify steps to update Cognito user email address with example Related to: aws-amplify/amplify-js#987 aws-amplify/amplify-cli#10773 * remove extra space * React native getting started guide updates (#4714) * small updates to getting started guide * clarified the inspector panel location * Expo CLI wording update * remove react-native-picker and react-native package * update to RN getting started guide * updated installation of React Native CLI * update setup steps * removed broken closing tags * fixed tag * removed open tag without closing tag * added closing tag * removes ionic * omg merge conflict merginng. Much shame. Very sad. Co-authored-by: Tim Nguyen <timngyn@gmail.com> Co-authored-by: Dan Kiuna <dkkiuna11@gmail.com> Co-authored-by: Thomas Leing <bluezebragames@gmail.com> Co-authored-by: Thomas Leing <leint@amazon.com> Co-authored-by: Kevin Old <kevold@amazon.com> Co-authored-by: wpeck-amplify <107895670+wpeck-amplify@users.noreply.github.com> Co-authored-by: wrpeck <40308049+wrpeck@users.noreply.github.com> Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com> Co-authored-by: dengdan154 <85711456+dengdan154@users.noreply.github.com> Co-authored-by: Di Wu <5d@users.noreply.github.com> Co-authored-by: siegerts <stephen.siegert@gmail.com> Co-authored-by: Abdallah Shaban <awshaban@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
React native getting started guide updates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.