fix bug so that top level fragments are included in search index #4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 8c6ef5a into db0d83a - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4384
Description of changes:
This small PR fixes a bug that was stopping all top level fragments from being indexed. Once live top level fragments will be indexed. This issue can be seen when searching on the docs site for "use existing amazon cognito resources" which currently only shows 2 search results but omits all of the /lib resources
Current Results
Example of a missing result
Another PR is on its way which will include the ability to index nested fragments
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.