Skip to content

Conversation

vijtrip2
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#951

Description of changes:

  • Fixing the generator.yaml so that apigatewayv2-controller can be auto-generated on next code-gen release.
  • Successfully generated and tested controller locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes to any of the generated code? I'd call that a success!

However, there should at least be an update to the generator.yaml and ack-generate-metadata.yaml files in the apis/v1alpha1/ folder?

@vijtrip2
Copy link
Contributor Author

No changes to any of the generated code? I'd call that a success!

However, there should at least be an update to the generator.yaml and ack-generate-metadata.yaml files in the apis/v1alpha1/ folder?

I did not publish generated code in this PR. I am relying on new autogenerate feature to generate the controller for us.
This is proactive change that will help auto-generate be successful.

@vijtrip2
Copy link
Contributor Author

vijtrip2 commented Sep 22, 2021

/hold

waiting for code-gen PR#202 to get merged.

@ack-bot ack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2021
@vijtrip2 vijtrip2 changed the title update primary_key for DomainName resource Update ACK runtime to v0.14.1 Sep 23, 2021
@vijtrip2 vijtrip2 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2021
@RedbackThomson
Copy link
Contributor

Thank you

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit b8e495d into aws-controllers-k8s:main Sep 23, 2021
@vijtrip2 vijtrip2 deleted the ack-main branch September 23, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants