Skip to content

Conversation

vijtrip2
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#951

Description of changes:

  • Use latest controller-gen release, which unblocks aws-sdk-go upgrade for apigatewayv2 controller
  • do not restrict map value type when using reflect.DeepEqual method

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work pushing out that nested maps PR in the controller-tools! I'm sure there will be a lot of happy developers elsewhere that benefit from that change.

I've left a comment regarding the use of DeepEqual below. LMK if you see the advantage in that work.

@RedbackThomson RedbackThomson changed the title Controller gen v0.7.0 Update to controller-gen v0.7.0 Sep 22, 2021
@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 3bae07c into aws-controllers-k8s:main Sep 22, 2021
@vijtrip2 vijtrip2 deleted the controller-gen-v0.7.0 branch September 22, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants