Fix creation of multiple alarms #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes: I discovered a bug in the controller's sdkFind logic that caused it to fail to create alarms in many cases. Basically, it was using
DescribeAlarms
with no alarm name input, so would get back a list of all alarms. If any alarms existed in the account already, it would determine the new alarm already existed and not create it.This fix adds a post_build_request hook to read_many so it will get back a list of just the one alarm it's trying to find.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.