Skip to content

Fix creation of multiple alarms #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Fix creation of multiple alarms #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a0a6c2
release v0.0.1
jessebye Jul 25, 2023
ecad8e8
fix: Correctly set input to DescribeAlarms
jessebye Aug 4, 2023
252ba0a
Merge branch 'aws-controllers-k8s:main' into main
jessebye Aug 4, 2023
ea8ac4a
update test to detect problem
jessebye Aug 4, 2023
ede00df
Merge branch 'main' of ssh://github.com/jessebye/ack-cloudwatch-contr…
jessebye Aug 4, 2023
35a2011
revert test changes
jessebye Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2023-07-24T21:35:44Z"
build_date: "2023-08-04T16:51:02Z"
build_hash: e9b68590da73ce9143ba1e4361cebdc1d876c81e
go_version: go1.20.6
go_version: go1.20.7
version: v0.26.1-7-ge9b6859-dirty
api_directory_checksum: e21bfad36ac581912d611c9c390ab4bd2c2fb46d
api_version: v1alpha1
aws_sdk_go_version: v1.44.303
generator_config_info:
file_checksum: bfca77347e9ccada9ee0c53136c169cdca88443b
file_checksum: 2440ba630b0f66b3e92fd740afcafbd79da6b0c4
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 2 additions & 0 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,7 @@ resources:
input_fields:
AlarmName: Name
hooks:
sdk_read_many_post_build_request:
template_path: hooks/metricalarm/sdk_read_many_post_build_request.go.tpl
sdk_delete_post_build_request:
template_path: hooks/metricalarm/sdk_delete_post_build_request.go.tpl
2 changes: 2 additions & 0 deletions generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,7 @@ resources:
input_fields:
AlarmName: Name
hooks:
sdk_read_many_post_build_request:
template_path: hooks/metricalarm/sdk_read_many_post_build_request.go.tpl
sdk_delete_post_build_request:
template_path: hooks/metricalarm/sdk_delete_post_build_request.go.tpl
2 changes: 2 additions & 0 deletions pkg/resource/metric_alarm/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions templates/hooks/metricalarm/sdk_read_many_post_build_request.go.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
input.SetAlarmNames([]*string{r.ko.Spec.Name})