Initialise spec.Code before setting the imageURI
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
ack-bot
added
the
do-not-merge/hold
Fixes aws-controllers-k8s/community#1480 The runtime panics observed in issue 1480 were mainly caused by the `sdk_read_one` hook we use for `Function` resource. The hook didn't correctly initialise `spec.Code`. This patch fixes the initalisation to avoid nil pointer panics when adopting function resources
a-hilaly
force-pushed
the
issue/1480
branch
from
b5984d8 to
682bfe2
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
Vandita2020
pushed a commit
to Vandita2020/ack-lambda-controller
that referenced
this pull request
Sep 29, 2022
…8s#55) Fixes aws-controllers-k8s/community#1480 The runtime panics observed in issue 1480 were mainly caused by the `sdk_read_one` hook we use for `Function` resource. The hook didn't correctly initialise `spec.Code`. This patch fixes the initialization to avoid nil pointer panics when adopting function resources By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
michaelhtm
pushed a commit
to rushmash91/lambda-controller
that referenced
this pull request
Feb 5, 2025
…llers-k8s#55) ### Update to ACK runtime `v0.23.0`, code-generator `v0.23.1` ---------- * ACK code-generator `v0.23.1` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.23.1) * ACK runtime `v0.23.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.23.0) ---------- NOTE: This PR increments the release version of service controller from `v0.0.24` to `v0.0.25` Once this PR is merged, release `v0.0.25` will be automatically created for `mq-controller` **Please close this PR, if you do not want the new patch release for `mq-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. installing controller-gen v0.9.2 ... ok. ==== building mq-controller ==== Copying common custom resource definitions into mq Building Kubernetes API objects for mq Generating deepcopy code for mq Generating custom resource definitions for mq Building service controller for mq Generating RBAC manifests for mq Running gofmt against generated code for mq Updating additional GitHub repository maintenance files ==== building mq-controller release artifacts ==== Building release artifacts for mq-v0.0.25 Generating common custom resource definitions Generating custom resource definitions for mq Generating RBAC manifests for mq ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws-controllers-k8s/community#1480
The runtime panics observed in issue 1480 were mainly caused by the
sdk_read_onehook we use forFunctionresource. The hook didn'tcorrectly initialise
spec.Code.This patch fixes the initialization to avoid nil pointer panics when
adopting function resources
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.