Skip to content

Initialise spec.Code before setting the imageURI #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Initialise spec.Code before setting the imageURI #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/resource/function/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion templates/hooks/function/sdk_read_one_post_set_output.go.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
if resp.Code != nil {
// We need to keep the desired .Code s3Bucket s3Key and s3ObjectVersion
// We need to keep the desired .Code s3Bucket s3Key and s3ObjectVersion
// part of the function's spec. So instead of setting Spec.Code to nil
// we only set ImageURI
//
// When adopting a Function resource, Spec.Code field should be manually
// initialised before injecting ImageURI.
if ko.Spec.Code == nil {
ko.Spec.Code = &svcapitypes.FunctionCode{}
}
if resp.Code.ImageUri != nil {
ko.Spec.Code.ImageURI = resp.Code.ImageUri
}
Expand Down