refactor(parser): Improve AppSync models with examples and descriptions #7330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances the AppSync parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for AppSync event parsing, following the pattern established in previous PRs. All field descriptions are based on official AWS AppSync documentation and include realistic examples from actual test events. Closes aws-powertools#7122
pull-request-size
bot
added
the
size/L
- Sanitize JWT token examples to use generic placeholders - Remove authorization header from examples to avoid hardcoded credentials - Replace sensitive UUIDs with generic placeholders - Address SonarQube security hotspots while maintaining example clarity
…spots - Remove token_use and auth_time fields from JWT claims examples - Sanitize OIDC subject identifier examples - Address remaining SonarCloud security concerns while maintaining example clarity
…hotspots - Simplify JWT claims examples to minimal required fields - Remove complex nested authentication data - Keep examples clear but security-compliant - Final resolution of SonarCloud security concerns
…tspots - Remove JWT claims examples that trigger security hotspots - Keep comprehensive field descriptions for developer guidance - Maintain functionality while ensuring security compliance - Final resolution of all SonarCloud security concerns
- Replace all hardcoded IP addresses with localhost and private network examples - Use 127.0.0.1 and 10.0.0.x addresses to avoid SonarCloud security hotspots - Addresses SonarCloud security concerns about hardcoded IP addresses - Final resolution of all security hotspots
…tspots - Remove all IP address examples from sourceIp fields and headers - Keep comprehensive field descriptions for developer guidance - Maintain functionality while ensuring complete security compliance - Final resolution of all SonarCloud security hotspots
- Format appsync.py file according to project standards using Ruff - Fix 13 additional linting issues automatically - Ensure all 1167 files pass formatting checks - Resolves GitHub Actions workflow failure in PR aws-powertools#7330
leandrodamascena
requested changes
Sep 8, 2025
There was a problem hiding this comment.
@dcabib thanks for working on this. I left some feedback and please run make format to fix the problems.
aws_lambda_powertools/utilities/parser/models/appsync_events.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/parser/models/appsync_events.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/parser/models/appsync_events.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/parser/models/appsync_events.py
Outdated
Show resolved
Hide resolved
|
leandrodamascena
approved these changes
Sep 9, 2025
hjgraca
approved these changes
Sep 9, 2025
hjgraca
approved these changes
Sep 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7330 +/- ##
========================================
Coverage 96.36% 96.36%
========================================
Files 275 275
Lines 13007 13007
Branches 968 968
========================================
Hits 12534 12534
Misses 366 366
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leandrodamascena
merged commit 3014dc6
into
aws-powertools:develop
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #7122
Summary
Enhances the AppSync parser models with field descriptions and examples using Pydantic's Field() functionality. This improvement provides better documentation and metadata for AppSync event parsing, following the pattern established in previous PRs.
Changes
Added Field() descriptions and examples to all AppSync parser model classes:
All field descriptions are based on official AWS AppSync documentation
Examples sourced from actual test events and AWS documentation
Maintains 100% backward compatibility - no breaking changes to type annotations or validation logic
Follows best practices from successful PRs (default=None pattern for Optional fields)
User experience
Customers will be able to see examples and descriptions when using AppSync parser models, providing:
Checklist
Is this a breaking change? No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
Closes #7122