-
Notifications
You must be signed in to change notification settings - Fork 171
Closed
Labels
internalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)loggerThis item relates to the Logger UtilityThis item relates to the Logger Utilitypending-releaseThis item has been merged and will be released soonThis item has been merged and will be released soontestsPRs that add or change testsPRs that add or change tests
Description
Summary
One of the unit tests in the Logger utility is failing
https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/17432536582/job/49494081506
There seems to be an extra parameter diff
that was passed in error. This is only seen in v22.19.0. Previous versions of Nodejs didn't pass that parameter.
Why is this needed?
The test is currently failing and blocking the pipeline
Which area does this relate to?
Tests
Solution
We can either make the test less strict by using toMatchObject
instead of toEqual
.
or, we could just include the diff
parameter to be expected.
Acknowledgment
- This request meets Powertools for AWS Lambda (TypeScript) Tenets
- Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET
Future readers
Please react with 👍 and your use case to help us understand customer demand.
dreamorosi
Metadata
Metadata
Assignees
Labels
internalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)loggerThis item relates to the Logger UtilityThis item relates to the Logger Utilitypending-releaseThis item has been merged and will be released soonThis item has been merged and will be released soontestsPRs that add or change testsPRs that add or change tests
Type
Projects
Status
Coming soon