Maintenance: improve linting checks #4549
Description
Summary
When reviewing the codebase we've noticed that there's a mismatch between the linting rules/expectations in the IDE and what's being linted as part of pre-commit hooks and CI.
This is because CI and hooks only notify the developer on errors, while the IDE also emits warnings and info level type of issues.
For example, here's a screenshot from a recent CI run; notice how even though there are linting issues, their severity makes them hidden and leaves the CI green.
Additionally, IDE issues are shown only if developers have the Biome extension/plugin installed, which might not be the case.
We should update our biome.json config file and raise the severity for all rules we care to error, so that they're captured by automations.
Why is this needed?
Over time, especially as we attract new contributors of varying degrees of skill level or AI usage, this type of inconsistency is bound to leave the codebase in a worse state due to subtle-but-not-critical issues being ignored by most linting automation.
Which area does this relate to?
Other
Solution
No response
Acknowledgment
- This request meets Powertools for AWS Lambda (TypeScript) Tenets
- Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET
Future readers
Please react with 👍 and your use case to help us understand customer demand.