Skip to content

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Aug 12, 2025

Summary

This PR adds verification steps to check the Description, which contains the Powertools version number, and the Layer version in the published artifact of the Layer Deployment (Partitions) step to automate the following steps of the Release workflow:

  • Verify GovCloud Layers (Gamma): Download the AWSLambdaPowertoolsTypeScriptV2-us-gov-east-1.json and AWSLambdaPowertoolsTypeScriptV2-us-gov-west-1.json ZIP files. Unzip the files, inspect the JSON files therein and ensure the version number in the Description field (i.e., Powertools for AWS Lambda (TypeScript) version 2.20.0) and the layer version in the LayerVersionArn field (i.e., arn:aws-us-gov:lambda:us-gov-east-1:164754790254:layer:AWSLambdaPowertoolsTypeScriptV2:32) are correct.
  • Verify GovCloud Layers (Prod): Download the AWSLambdaPowertoolsTypeScriptV2-us-gov-east-1.json and AWSLambdaPowertoolsTypeScriptV2-us-gov-west-1.json ZIP files. Unzip the files, inspect the JSON files therein and ensure the version number in the Description field (i.e., Powertools for AWS Lambda (TypeScript) version 2.20.0) and the layer version in the LayerVersionArn field (i.e., arn:aws-us-gov:lambda:us-gov-west-1:165093116878:layer:AWSLambdaPowertoolsTypeScriptV2:32) are correct.
  • Verify China Layer (Gamma): Download the AWSLambdaPowertoolsTypeScriptV2-cn-north-1.json ZIP file. Unzip the file, inspect the JSON file therein and ensure the version number in the Description field (i.e., Powertools for AWS Lambda (TypeScript) version 2.20.0) and the layer version in the LayerVersionArn field (i.e., arn:aws-cn:lambda:cn-north-1:498595349401:layer:AWSLambdaPowertoolsTypeScriptV2:32) are correct.
  • Verify China Layer (Prod): Download the AWSLambdaPowertoolsTypeScriptV2-cn-north-1.json ZIP file. Unzip the file, inspect the JSON file therein and ensure the version number in the Description field (i.e., Powertools for AWS Lambda (TypeScript) version 2.20.0) and the layer version in the LayerVersionArn field (i.e., arn:aws-cn:lambda:cn-north-1:498634801083:layer:AWSLambdaPowertoolsTypeScriptV2:32) are correct.

Changes

Please provide a summary of what's being changed

  • Added a verification step similar to that of the verification of the SHA. The verification step verifies if the local layer description and number matches with the remote layer description and number.
  • Removed the manual verification steps mentioned in the Maintainers documentation in the release workflow

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4182


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Aug 12, 2025
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Aug 12, 2025
@sdangol sdangol requested review from sthulb and svozza August 12, 2025 09:08
@svozza
Copy link
Contributor

svozza commented Aug 12, 2025

We should also update the maintainers documentation to remove the manual verification steps for this listed there.

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Aug 12, 2025
@pull-request-size pull-request-size bot added size/M PR between 30-99 LOC and removed size/XS PR between 0-9 LOC labels Aug 12, 2025
@sdangol
Copy link
Contributor Author

sdangol commented Aug 12, 2025

@svozza I've updated the docs as well

@sdangol sdangol force-pushed the improv/release-workflow branch from 1f527b0 to fbcd743 Compare August 12, 2025 09:38
svozza
svozza previously approved these changes Aug 12, 2025
Co-authored-by: Stefano Vozza <svozza@amazon.com>
Co-authored-by: Stefano Vozza <svozza@amazon.com>
Copy link

@dreamorosi dreamorosi merged commit 60bf96e into main Aug 12, 2025
36 checks passed
@dreamorosi dreamorosi deleted the improv/release-workflow branch August 12, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Verify Output of Layer Deployment (Partitions) GitHub Action
3 participants