Skip to content

Conversation

svozza
Copy link
Contributor

@svozza svozza commented Sep 9, 2025

Summary

Splits the large (~2000 line) Router test file into smaller files partitioned by functionality

Changes

Separate test files based on these areas:

  • Basic routing functionality
  • Middleware (global and route specific)
  • Decorators
  • Error handling
  • Logging

Issue number: closes #4438


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@svozza svozza added this to the Event Handler Beta (priority) milestone Sep 9, 2025
@svozza svozza requested review from dreamorosi and sdangol September 9, 2025 09:46
@svozza svozza self-assigned this Sep 9, 2025
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Sep 9, 2025
@pull-request-size pull-request-size bot added the size/XXL PRs with 1K+ LOC, largely documentation related label Sep 9, 2025
@svozza svozza added the event-handler This item relates to the Event Handler Utility label Sep 9, 2025
Copy link
Contributor

@sdangol sdangol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a sonarqube finding

@svozza svozza force-pushed the event-handler/split-up-base-router-tests branch from f3ce510 to f794c07 Compare September 9, 2025 10:07
@svozza svozza force-pushed the event-handler/split-up-base-router-tests branch from f794c07 to 4278f96 Compare September 9, 2025 10:10
Copy link

sonarqubecloud bot commented Sep 9, 2025

@svozza svozza requested a review from sdangol September 9, 2025 10:11
@svozza
Copy link
Contributor Author

svozza commented Sep 9, 2025

There's a sonarqube finding

Fixed

@svozza svozza merged commit 91a1ec4 into main Sep 9, 2025
37 checks passed
@svozza svozza deleted the event-handler/split-up-base-router-tests branch September 9, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

event-handler This item relates to the Event Handler Utility size/XXL PRs with 1K+ LOC, largely documentation related tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Split Rest Event Handler BaseRouter Tests Into Multiple Files

2 participants