chore(event-handler): rename variables to reflect that options object is now a RequestContext #4460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is now a RequestContext
boring-cyborg
bot
added
event-handler
sdangol
previously approved these changes
Sep 10, 2025
dreamorosi
reviewed
Sep 10, 2025
svozza
force-pushed
the
event-hanlder-handleroprions-to-requestcontext
branch
from
650c1c9 to
081946b
Compare
sdangol
reviewed
Sep 10, 2025
|
sdangol
approved these changes
Sep 10, 2025
dreamorosi
deleted the
event-hanlder-handleroprions-to-requestcontext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reflects the change of type from
HandlerOptionstoRequestContextmade in #4439 by updating class variables, JSDocs and the tests.Changes
reqCtxinstead ofoptionsas the name for any parameter of typeRequestContextreqCtxinstead ofoptionsas the name for any parameter of typeRequestContextIssue number: closes #4459
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.