feat(event-handler): added includeRouter method to split routes
#4573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
event-handler
dreamorosi
requested changes
Sep 24, 2025
packages/event-handler/tests/unit/rest/Router/basic-routing.test.ts
Outdated
Show resolved
Hide resolved
packages/event-handler/tests/unit/rest/Router/basic-routing.test.ts
Outdated
Show resolved
Hide resolved
svozza
reviewed
Sep 24, 2025
|
dreamorosi
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
includeRoutermethod to allows merging routes, context, and middleware from one router instance into another.Changes
mergemethods on the Route Handler and Error Handler registries to merge error handlers and routesincludeRoutermethod on the Router to merge context, registries and middlewaresIssue number: closes #4481
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.