fix: rm eslint & prettier from ignoreDependencies in knip config #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konokenj
approved these changes
Dec 11, 2024
Contributor
konokenj
left a comment
konokenj
left a comment
There was a problem hiding this comment.
LGTM. Thank you quick fix!
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated
depchecktoknipin #924 , we forgot to removeprettierandeslintfromignoreDependenciesinknip.config.ts. Therefore I've removed them.ref: #924 (review)
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).