add generation step to openqasm integ tests #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/openqasm_generation #406 +/- ##
==============================================================
Coverage 100.00% 100.00%
==============================================================
Files 79 79
Lines 5691 5583 -108
Branches 816 780 -36
==============================================================
- Hits 5691 5583 -108
Continue to review full report at Codecov.
|
kshitijc
reviewed
Jul 19, 2022
ajberdy
commented
Jul 20, 2022
Comment on lines
+257
to
+271
| factors = [] | ||
| use_qubits = iter(target) | ||
| for obs in self._factors: | ||
| obs_target = QubitSet() | ||
| num_qubits = int(np.log2(obs.to_matrix().shape[0])) | ||
| for _ in range(num_qubits): | ||
| obs_target.add(next(use_qubits)) | ||
| factors.append( | ||
| obs.to_ir( | ||
| target=obs_target, | ||
| ir_type=IRType.OPENQASM, | ||
| serialization_properties=serialization_properties, | ||
| ) | ||
| ) | ||
| for obs, targ in zip(self._factors, target) | ||
| ) | ||
| return " @ ".join(factors) |
There was a problem hiding this comment.
Fix: this change allows 2q hermitians to consume 2 qubits of the target
ajberdy
commented
Jul 20, 2022
| def _to_openqasm(self, serialization_properties: OpenQASMSerializationProperties) -> str: | ||
| if not self.target: | ||
| return "#pragma braket result probability" | ||
| return "#pragma braket result probability all" |
There was a problem hiding this comment.
Service does not currently support exclusion of all due to lark restrictions
ajberdy
commented
Jul 20, 2022
ajberdy
commented
Jul 20, 2022
kshitijc
reviewed
Jul 27, 2022
| result, shots, expected_var, expected_mean, expected_eigs | ||
| ) | ||
| tasks = (circuit,) if not test_program else (circuit, circuit.to_ir(ir_type=IRType.OPENQASM)) | ||
| print(circuit.to_ir(ir_type=IRType.OPENQASM)) |
kshitijc
approved these changes
Jul 27, 2022
ajberdy
commented
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#328
Description of changes:
Add openqasm generation step to openqasm integ tests.
Testing done:
tox -e integ-tests -- -k openqasm
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.