Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 24, 2025

Follows CDK best practices by using specific imports from aws-cdk-lib/core instead of importing the entire aws-cdk-lib package.

Affects all JavaScript and TypeScript templates across app, sample-app, and lib init types.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 24, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 24, 2025 10:02
@mrgrain mrgrain changed the title fix(aws-cdk): update init template imports to use aws-cdk-lib/core fix(aws-cdk): init template imports not following best practices to use aws-cdk-lib/core Oct 24, 2025
@mrgrain mrgrain changed the title fix(aws-cdk): init template imports not following best practices to use aws-cdk-lib/core fix(aws-cdk): init template imports not following best practices to use aws-cdk-lib/core Oct 24, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.04%. Comparing base (3d7b09b) to head (8576016).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
- Coverage   83.29%   83.04%   -0.26%     
==========================================
  Files          71       71              
  Lines       10401    10401              
  Branches     1311     1305       -6     
==========================================
- Hits         8664     8637      -27     
- Misses       1698     1725      +27     
  Partials       39       39              
Flag Coverage Δ
suite.unit 83.04% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit a560d1e Oct 24, 2025
53 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/aws-cdk/update-init-template-imports branch October 24, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants