Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stepfunctions-tasks: enable guardrail and trace settings for BedrockInvokeModel #30425

Closed
1 of 2 tasks
mazyu36 opened this issue Jun 2, 2024 · 3 comments · Fixed by #30426 or rwlxxvii/containers#185 · May be fixed by gitafolabi/kreuzlaker#2, NOUIY/aws-solutions-constructs#113 or NOUIY/aws-solutions-constructs#114
Closed
1 of 2 tasks

stepfunctions-tasks: enable guardrail and trace settings for BedrockInvokeModel #30425

mazyu36 opened this issue Jun 2, 2024 · 3 comments · Fixed by #30426 or rwlxxvii/containers#185 · May be fixed by gitafolabi/kreuzlaker#2, NOUIY/aws-solutions-constructs#113 or NOUIY/aws-solutions-constructs#114
Labels
@aws-cdk/aws-stepfunctions-tasks feature-request A feature should be added or improved. p2 pr/work-in-progress This PR is a draft and needs further work.

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jun 2, 2024

Describe the feature

Bedrock InvokeModel API supports guardrail configuration and trace.

But in BedrockInvokeModel, both options are not supported.

Use Case

To use guardrail and trace when invoke the Bedrock model.

Proposed Solution

Add guardrailConfiguration and trace property to the BedrockInvokeModel class.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.143.0

Environment details (OS name and version, etc.)

all
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 2, 2024
@mazyu36 mazyu36 mentioned this issue Jun 2, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Jun 3, 2024
Closed
@ashishdhingra ashishdhingra self-assigned this Jun 3, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 3, 2024
@ashishdhingra
Copy link
Contributor

Appears to be a valid feature request. @mazyu36 Thanks for the PR.

@ashishdhingra ashishdhingra added p2 pr/work-in-progress This PR is a draft and needs further work. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jun 3, 2024
@ashishdhingra ashishdhingra removed their assignment Jun 3, 2024
@mazyu36 mazyu36 changed the title (stepfunctions-tasks): enable guardrail and trace settings for BedrockInvokeModel stepfunctions-tasks: enable guardrail and trace settings for BedrockInvokeModel Jun 4, 2024
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Closed
@mergify mergify bot closed this as completed in #30426 Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

msambol pushed a commit to msambol/aws-cdk that referenced this issue Jul 5, 2024
@mazyu36
feat(stepfunctions-tasks): add guardrailConfiguration and trace prope…
772b1d1 
…rty to the BedrockInvokeModel (aws#30426)

### Issue # (if applicable)

Closes aws#30425 

### Reason for this change
In the current [BedrockInvokeModel](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_stepfunctions_tasks.BedrockInvokeModel.html), guardrail configuration and trace for the invocation are not supported.



### Description of changes
Add `gurdrailConfiguration` and `trace` property to the `BedrockInvokeModel`



### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ pushed a commit that referenced this issue Jul 10, 2024
@mazyu36 @GavinZZ
feat(stepfunctions-tasks): add guardrailConfiguration and trace prope…
baac4ff 
…rty to the BedrockInvokeModel (#30426)

### Issue # (if applicable)

Closes #30425 

### Reason for this change
In the current [BedrockInvokeModel](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_stepfunctions_tasks.BedrockInvokeModel.html), guardrail configuration and trace for the invocation are not supported.



### Description of changes
Add `gurdrailConfiguration` and `trace` property to the `BedrockInvokeModel`



### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks feature-request A feature should be added or improved. p2 pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions-tasks): add guardrailConfiguration and trace property to the BedrockInvokeModel mazyu36/aws-cdk
[Snyk] Upgrade aws-cdk-lib from 2.144.0 to 2.153.0 rwlxxvii/containers
[Snyk] Upgrade aws-cdk from 2.44.0 to 2.150.0 gitafolabi/kreuzlaker
[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs
[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs
[Snyk] Upgrade @aws-cdk/cloudformation-diff from 2.99.1 to 2.155.0 NOUIY/aws-solutions-constructs
[Snyk] Upgrade aws-cdk from 2.99.1 to 2.155.0 NOUIY/aws-solutions-constructs
[Snyk] Upgrade @aws-cdk/cloudformation-diff from 2.99.1 to 2.156.0 NOUIY/aws-solutions-constructs
[Snyk] Upgrade aws-cdk from 2.99.1 to 2.156.0 NOUIY/aws-solutions-constructs
[Snyk] Upgrade aws-cdk-lib from 2.148.0 to 2.149.0 codu-code/codu
3 participants
@mazyu36 @aws-cdk-automation @ashishdhingra