Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudwatch-actions): add ssm opsitem action for cloudwatch alarm #16923

Merged
merged 17 commits into from
Feb 1, 2022

Conversation

vportascarta
Copy link
Contributor

@vportascarta vportascarta commented Oct 12, 2021

This small PR will add SSM OpsItem action to cloudwatch alarm.
The arn format was taken from the alarm UI (in view source) and with all the parameters (severity and category)

closes #16861


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 12, 2021

@peterwoodworth peterwoodworth changed the title feat(aws-cloudwatch-actions): add ssm opsitem action for cloudwatch alarm feat(aws-cloudwatch-actions): add ssm opsitem action for cloudwatch alarm Oct 21, 2021
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for contributing, @vportascarta ! I just have a couple extremely minor comments on the docs.

packages/@aws-cdk/aws-cloudwatch-actions/lib/ssm.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch-actions/lib/ssm.ts Outdated Show resolved Hide resolved
vportascarta and others added 2 commits November 24, 2021 14:16
Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
@vportascarta
Copy link
Contributor Author

@madeline-k It's all good for me.

madeline-k
madeline-k previously approved these changes Jan 11, 2022
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! @vportascarta 😄

@mergify mergify bot dismissed madeline-k’s stale review January 11, 2022 01:55

Pull request has been modified.

Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I approved prematurely! We need an update to the README to describe this new feature as well. https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/aws-cloudwatch-actions/README.md

@mergify mergify bot dismissed madeline-k’s stale review January 17, 2022 13:06

Pull request has been modified.

madeline-k
madeline-k previously approved these changes Jan 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@madeline-k
Copy link
Contributor

The build is failing now because this module has been migrated to use the Assertions library for unit tests. You will need to update the ssm.test.ts unit tests to use it as well. Should be a simple change! Let me know if you have questions @vportascarta . Here is the PR to migrate the rest of this module for reference: #18539

@mergify mergify bot dismissed madeline-k’s stale review January 21, 2022 13:25

Pull request has been modified.

@madeline-k madeline-k changed the title feat(aws-cloudwatch-actions): add ssm opsitem action for cloudwatch alarm feat(cloudwatch-actions): add ssm opsitem action for cloudwatch alarm Jan 31, 2022
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vportascarta! This is ready to merge, and should go out in the next weekly release.

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

packages/@aws-cdk/aws-cloudwatch-actions/README.md Outdated Show resolved Hide resolved
Fix compilation errors in README example
@mergify mergify bot dismissed madeline-k’s stale review February 1, 2022 06:00

Pull request has been modified.

madeline-k
madeline-k previously approved these changes Feb 1, 2022
Accidentally removed them in prior commit.
@mergify mergify bot dismissed madeline-k’s stale review February 1, 2022 18:40

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9d71bef
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9380885 into aws:master Feb 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…aws#16923)

This small PR will add SSM OpsItem action to cloudwatch alarm.
The arn format was taken from the alarm UI (in view source) and with all the parameters (severity and category)

closes aws#16861 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cloudwatch-actions): Add the possibility to have SSM OpsItem Action
3 participants