-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudwatch-actions): add ssm opsitem action for cloudwatch alarm #16923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you for contributing, @vportascarta ! I just have a couple extremely minor comments on the docs.
Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
@madeline-k It's all good for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! @vportascarta 😄
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I approved prematurely! We need an update to the README to describe this new feature as well. https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/aws-cloudwatch-actions/README.md
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The build is failing now because this module has been migrated to use the Assertions library for unit tests. You will need to update the |
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vportascarta! This is ready to merge, and should go out in the next weekly release.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fix compilation errors in README example
Pull request has been modified.
Accidentally removed them in prior commit.
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…aws#16923) This small PR will add SSM OpsItem action to cloudwatch alarm. The arn format was taken from the alarm UI (in view source) and with all the parameters (severity and category) closes aws#16861 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This small PR will add SSM OpsItem action to cloudwatch alarm.
The arn format was taken from the alarm UI (in view source) and with all the parameters (severity and category)
closes #16861
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license