Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-cloudwatch-actions): Add the possibility to have SSM Incident Action #20553

Closed
wants to merge 1 commit into from

Conversation

dosatos
Copy link

@dosatos dosatos commented May 31, 2022

This small PR will add SSM Incident action to cloudwatch alarm.
The arn format was taken from the UI console (under Incident Manager Response Plan)

closes #20552

Used #16923 as a reference

…tion

This small PR will add SSM Incident action to cloudwatch alarm.
The arn format was taken from the UI console (under Incident Manager Response Plan)
@gitpod-io
Copy link

gitpod-io bot commented May 31, 2022

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels May 31, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 31, 2022 12:06
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a85da25
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main June 2, 2022 09:02
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments on this one.

@@ -3,3 +3,4 @@ export * from './autoscaling';
export * from './sns';
export * from './ec2';
export * from './ssm';
export * from './ssm-incidents';
Copy link
Contributor

@comcalvi comcalvi Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export * from './ssm-incidents';
export * from './ssm-incidents';

// Create an Incident Manager incident based on a specific response plan
alarm.addAlarmAction(
new actions.SsmIncidentAction(
'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName'
'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName',

@@ -0,0 +1,20 @@
import * as cloudwatch from '@aws-cdk/aws-cloudwatch';
Copy link
Contributor

@comcalvi comcalvi Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic should be moved into ssm.ts.

Comment on lines +8 to +9
constructor(private readonly responsePlanArn: string) {
}
Copy link
Contributor

@comcalvi comcalvi Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
constructor(private readonly responsePlanArn: string) {
}
constructor(private readonly responsePlanArn: string) { }

@TheRealAmazonKendra
Copy link
Contributor

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

callumthomson added a commit to callumthomson/aws-cdk that referenced this pull request Jul 15, 2022
Finishes work originally contributed by @dosatos by addressing changes requested by @comcalvi in aws#20553
closes aws#20552
@dosatos
Copy link
Author

dosatos commented Jul 19, 2022

Sorry, I have been on a month long vacation and could not check-in earlier.
From what I see, this efforts has been carried over in this work: #21167

mergify bot pushed a commit that referenced this pull request Aug 10, 2022
Finishes work originally contributed by @dosatos by addressing changes requested by @comcalvi in [#20553](#20553)

closes [#20552](#20552)
josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
…21167)

Finishes work originally contributed by @dosatos by addressing changes requested by @comcalvi in [aws#20553](aws#20553)

closes [aws#20552](aws#20552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cloudwatch-actions): Add the possibility to have SSM Incident Action
5 participants