-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-cloudwatch-actions): Add the possibility to have SSM Incident Action #20553
Conversation
…tion This small PR will add SSM Incident action to cloudwatch alarm. The arn format was taken from the UI console (under Incident Manager Response Plan)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments on this one.
@@ -3,3 +3,4 @@ export * from './autoscaling'; | |||
export * from './sns'; | |||
export * from './ec2'; | |||
export * from './ssm'; | |||
export * from './ssm-incidents'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export * from './ssm-incidents'; | |
export * from './ssm-incidents'; | |
// Create an Incident Manager incident based on a specific response plan | ||
alarm.addAlarmAction( | ||
new actions.SsmIncidentAction( | ||
'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName' | |
'arn:aws:ssm-incidents::123456789012:response-plan/ResponsePlanName', |
@@ -0,0 +1,20 @@ | |||
import * as cloudwatch from '@aws-cdk/aws-cloudwatch'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic should be moved into ssm.ts
.
constructor(private readonly responsePlanArn: string) { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constructor(private readonly responsePlanArn: string) { | |
} | |
constructor(private readonly responsePlanArn: string) { } |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Sorry, I have been on a month long vacation and could not check-in earlier. |
This small PR will add SSM Incident action to cloudwatch alarm.
The arn format was taken from the UI console (under Incident Manager Response Plan)
closes #20552
Used #16923 as a reference