feat(aws-cloudwatch-actions): add ssm incidents as alarm action

[callumthomson]

Finishes work originally contributed by @dosatos by addressing changes requested by @comcalvi in #20553

closes #20552

[gitpod-io]

[TheRealAmazonKendra]

Overall this looks great! I think we'll need an integration test for this, though. Could you please add one?

Pull request has been modified.

[callumthomson]

I've added an integration test using IntegTest, but I think more is needed. Could you please let me know if this is a step in the right direction, @TheRealAmazonKendra ?

[TheRealAmazonKendra]

@callumthomson Your integ test file is what we're looking for. We just need you to generate the expected template and assets. See our integration test guide.

I've also added a few comments inline regarding the specific errors in the build.

Pull request has been modified.

[callumthomson]

@TheRealAmazonKendra I've added in the requested changes. Please let me know any further desired amendments.

[TheRealAmazonKendra]

Just one comment inline but it also looks like your test can use SSM Incident as alarm action isn't working because the partition is a reference in the actual output, but you've used a literal in your expected output. We just need to get this test working so the build passes. If you have any questions about this, please let me know.

Pull request has been modified.

[callumthomson]

@TheRealAmazonKendra that seems to be working now, but there appears to have been an error in aws-appsync:

@aws-cdk/aws-appsync: Verifying integration test snapshots...
@aws-cdk/aws-appsync: /codebuild/output/src184008709/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-appsync/lib/graphqlapi.js:371
@aws-cdk/aws-appsync:             throw Error('API key expiration must be between 1 and 365 days.');
@aws-cdk/aws-appsync:             ^
@aws-cdk/aws-appsync: Error: API key expiration must be between 1 and 365 days.
@aws-cdk/aws-appsync:     at GraphqlApi.createAPIKey (/codebuild/output/src184008709/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-appsync/lib/graphqlapi.js:371:19)
@aws-cdk/aws-appsync:     at new GraphqlApi (/codebuild/output/src184008709/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-appsync/lib/graphqlapi.js:188:40)
@aws-cdk/aws-appsync:     at Object.<anonymous> (/codebuild/output/src184008709/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-appsync/test/integ.auth-apikey.js:23:13)
@aws-cdk/aws-appsync:     at Module._compile (internal/modules/cjs/loader.js:1085:14)
@aws-cdk/aws-appsync:     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
@aws-cdk/aws-appsync:     at Module.load (internal/modules/cjs/loader.js:950:32)
@aws-cdk/aws-appsync:     at Function.Module._load (internal/modules/cjs/loader.js:790:12)
@aws-cdk/aws-appsync:     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
@aws-cdk/aws-appsync:     at internal/main/run_main_module.js:17:47

[TheRealAmazonKendra]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: ee7e8b8
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).