Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(region-info): add initial region info for ap-south-2 #23167

Merged
merged 3 commits into from
Dec 8, 2022
Merged

chore(region-info): add initial region info for ap-south-2 #23167

merged 3 commits into from
Dec 8, 2022

Conversation

cgarvis
Copy link
Contributor

@cgarvis cgarvis commented Nov 30, 2022

Closes #23069

@gitpod-io
Copy link

gitpod-io bot commented Nov 30, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team November 30, 2022 01:12
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Nov 30, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 30, 2022
Naumel
Naumel reviewed Nov 30, 2022
View reviewed changes
Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the failed build

@aws-cdk/region-info: FAIL test/region-info.test.js
@aws-cdk/region-info:   â—� built-in data is correct

packages/@aws-cdk/region-info/build-tools/fact-tables.ts Show resolved Hide resolved
@mrgrain mrgrain self-assigned this Dec 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eec24d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d1261c0 into main Dec 8, 2022
@mergify mergify bot deleted the ap-south-2 branch December 8, 2022 14:46
@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Dec 9, 2022
@cgarvis
chore(region-info): add initial region info for ap-south-2 (aws#23167)
b14d0e7 
Closes aws#23069
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Jan 20, 2023
@cgarvis
chore(region-info): add initial region info for ap-south-2 (aws#23167)
6c37a08 
Closes aws#23069
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Feb 22, 2023
@cgarvis
chore(region-info): add initial region info for ap-south-2 (aws#23167)
02fd61e 
Closes aws#23069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain left review comments

@Naumel Naumel Naumel approved these changes

Assignees

@mrgrain mrgrain

Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

region-info: ap-south-2 not defined
4 participants
@cgarvis @aws-cdk-automation @mrgrain @Naumel