fix(lambda-nodejs): pnpm installs frozen lockfile in a CI environment

[Tucker-Eric]

pnpm automatically enables --frozen-lockfile in CI environments which breaks NodejsFunction local bundling.

This change appends the --no-prefer-frozen-lockfile flag as described in pnpm/pnpm#1994 (comment)

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[Tucker-Eric]

Looking for an Exemption Request for the integration test as well.

[TheRealAmazonKendra]

Looking for an Exemption Request for the integration test as well.

To provide the exemption request, can you please describe how this was manually tested? I am inclined to agree that this is difficult to write an automated test for.

[TheRealAmazonKendra]

I'm removing the exemption request label for now. Please use a quote reply to my last message to add it back when you respond to my question so I see that this needs another look.

Thanks for you work here!

[Tucker-Eric]

Looking for an Exemption Request for the integration test as well.

To provide the exemption request, can you please describe how this was manually tested? I am inclined to agree that this is difficult to write an automated test for.

Hey @TheRealAmazonKendra! Appreciate your help with this!

This was manually tested locally using the command dumped in the error output of the current command.

Removing/replacing the asset staging path with a local one and rerunning the same commands in order (with the CI=true env variable to mimmic a CI environment) the following commands were run.

without --no-prefer-frozen-lockfile

mkdir asset-staging && \
    echo '{"dependencies":{"pg":"8.10.0"}}' > "asset-staging/package.json" && \
    cp "pnpm-lock.yaml" "asset-staging/pnpm-lock.yaml" && \
    cd asset-staging && \
    CI=true pnpm install --config.node-linker=hoisted --config.package-import-method=clone-or-copy && \
    rm "node_modules/.modules.yaml"

with --no-prefer-frozen-lockfile

mkdir asset-staging && \
    echo '{"dependencies":{"pg":"8.10.0"}}' > "asset-staging/package.json" && \
    cp "pnpm-lock.yaml" "asset-staging/pnpm-lock.yaml" && \
    cd asset-staging && \
    CI=true pnpm install --config.node-linker=hoisted --config.package-import-method=clone-or-copy --no-prefer-frozen-lockfile && \
    rm "node_modules/.modules.yaml"

[TheRealAmazonKendra]

Thank you for your contribution!

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[TheRealAmazonKendra]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 764ca2e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[ofhouse]

I there any ETA when this fix will be published?
Tested it with aws-cdk-lib@2.72.1 but it seems like this was not part of the release: https://unpkg.com/browse/aws-cdk-lib@2.72.1/aws-lambda-nodejs/lib/package-manager.js