-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions-tasks): allow BedrockInvokeModel to use JsonPath #30298
Conversation
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/bedrock/invoke-model.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/bedrock/invoke-model.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/bedrock/invoke-model.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/test/bedrock/invoke-model.test.ts
Show resolved
Hide resolved
…o specify input/output S3 URIs
2b7adef
to
d560c33
Compare
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
0910098
to
e0cdaf6
Compare
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
updating manually since mergifyio update is failing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #29229.
Reason for this change
When trying to use JsonPath to specify the S3 URIs that BedrockInvokeModel will read from and write from, you get an error.
Example of the Error message:
jsii.errors.JavaScriptError: Error: Field references must be the entire string, cannot concatenate them (found 's3://${Token[prompt_bucket.348]}/${Token[prompt_key.349]}')
Description of changes
Extended the inputPath property to be allowed as an input value for the task state.
Instead of adding a new S3Uri props in current
BedrockInvokeModelProps
as proposed in the original issue, leveraged theinputPath
property that is already defined insfn.TaskStateBaseProps
and being extended byBedrockInvokeModelInputProps
andBedrockInvokeModelOutputProps
Limitation: We cannot limit the resource policy to specific input token for which the value might be coming from the prompt, so had to keep it as [*] here.
Description of how you validated changes
Added unit tests.
Successful deployment of integration tests in the account.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license