Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bedrock): support missing model versions in Amazon Bedrock model #30324

Merged
merged 6 commits into from
May 27, 2024

Conversation

yasomaru
Copy link
Contributor

@yasomaru yasomaru commented May 24, 2024

Issue # (if applicable)

N/A

Reason for this change

Compare with the guide and add missing models.

Description of changes

Added the following models.

  • Amazon:
    • amazon.titan-text-lite-v1
    • amazon.titan-text-premier-v1:0
    • amazon.titan-embed-text-v2:0
  • Cohere:
    • cohere.command-r-v1:0
    • cohere.command-r-plus-v1:0
  • Meta
    • meta.llama3-8b-instruct-v1:0
    • meta.llama3-70b-instruct-v1:0
  • Mistral AI
    • mistral.mistral-large-2402-v1:0

Checklist

@aws-cdk-automation aws-cdk-automation requested a review from a team May 24, 2024 07:24
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels May 24, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 24, 2024
@aaythapa aaythapa self-assigned this May 24, 2024
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change. The added models LGTM.

Copy link
Contributor

mergify bot commented May 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 27, 2024
Copy link
Contributor

mergify bot commented May 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 127c0d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c03cdab into aws:main May 27, 2024
9 checks passed
Copy link
Contributor

mergify bot commented May 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@yasomaru yasomaru deleted the support-missing-model-version branch May 28, 2024 00:00
atanaspam pushed a commit to atanaspam/aws-cdk that referenced this pull request Jun 3, 2024
aws#30324)

### Issue # (if applicable)

N/A

### Reason for this change



Compare with [the guide](https://docs.aws.amazon.com/bedrock/latest/userguide/model-ids.html) and add missing models.


### Description of changes


Added the following models.

- Amazon: 
   - amazon.titan-text-lite-v1
   - amazon.titan-text-premier-v1:0
   - amazon.titan-embed-text-v2:0
- Cohere:
   - cohere.command-r-v1:0
   - cohere.command-r-plus-v1:0
- Meta
   - meta.llama3-8b-instruct-v1:0
   - meta.llama3-70b-instruct-v1:0
- Mistral AI
   - mistral.mistral-large-2402-v1:0

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this pull request Jun 10, 2024
aws#30324)

### Issue # (if applicable)

N/A

### Reason for this change



Compare with [the guide](https://docs.aws.amazon.com/bedrock/latest/userguide/model-ids.html) and add missing models.


### Description of changes


Added the following models.

- Amazon: 
   - amazon.titan-text-lite-v1
   - amazon.titan-text-premier-v1:0
   - amazon.titan-embed-text-v2:0
- Cohere:
   - cohere.command-r-v1:0
   - cohere.command-r-plus-v1:0
- Meta
   - meta.llama3-8b-instruct-v1:0
   - meta.llama3-70b-instruct-v1:0
- Mistral AI
   - mistral.mistral-large-2402-v1:0

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants