Skip to content

Conversation

majanjua-amzn
Copy link
Contributor

Issue # (if applicable)

N/A

Reason for this change

B3 propagator currently drops trace state and baggage if it comes after either of the propagators responsible for propagating these informations. It provides no functionality and only blocks baggage in the current state.

This blocks certain AWS X-Ray features from being used effectively without asking users to override the default propagators

Description of changes

  • Removed B3 propagator from default propagators environment variable list

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Confirmed with SME wangzlei@ that B3 is no longer needed, as per owners listed in https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/aws-xray-propagator

Ran manual tests by deploying applications hosted in both EC2 and EKS with various propagator configurations that exclude B3 using Application Signals on Java and verified all Application Signals behaviour was functional and as expected.

Removed the B3 default propagator in ADOT Java that is applied in non-CDK environments and verified the Application Signals E2E tests passed: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/17587061009/job/49960543385

(Failed jobs are due to misconfiguration of unrelated actions)

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Sep 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 16, 2025 20:27
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@majanjua-amzn majanjua-amzn changed the title fix(applicationsignals-alpha): Remove B3 from default propagators chore(applicationsignals-alpha): Remove B3 from default propagators Sep 16, 2025
@majanjua-amzn majanjua-amzn marked this pull request as draft September 16, 2025 23:27
@majanjua-amzn majanjua-amzn marked this pull request as ready for review September 16, 2025 23:27
@majanjua-amzn majanjua-amzn changed the title chore(applicationsignals-alpha): Remove B3 from default propagators chore(applicationsignals-alpha): remove B3 from default propagators Sep 17, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 17, 2025 16:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@majanjua-amzn majanjua-amzn force-pushed the patch-1 branch 2 times, most recently from 714055b to 3253cb7 Compare September 24, 2025 16:08
@alvazjor alvazjor self-assigned this Sep 25, 2025
alvazjor
alvazjor previously approved these changes Sep 25, 2025
@mergify mergify bot added the queued label Sep 25, 2025
Copy link
Contributor

mergify bot commented Sep 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
Copy link
Contributor

mergify bot commented Sep 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot removed the queued label Sep 25, 2025
Copy link
Contributor

mergify bot commented Sep 25, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Contributor

mergify bot commented Sep 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

B3 propagator currently drops trace state and baggage if it comes after either of the propagators responsible for propagating these informations. It provides no functionality and only blocks baggage in the current state.
@mergify mergify bot dismissed alvazjor’s stale review September 25, 2025 16:25

Pull request has been modified.

alvazjor
alvazjor previously approved these changes Sep 26, 2025
@mergify mergify bot added the queued label Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed alvazjor’s stale review September 26, 2025 11:27

Pull request has been modified.

alvazjor
alvazjor previously approved these changes Sep 26, 2025
@mergify mergify bot added the queued label Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify mergify bot removed the queued label Sep 26, 2025
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35510 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries.
Waiting for the branch protection required status checks to be validated.

You can check the last failing draft PR here: #35594.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed alvazjor’s stale review September 26, 2025 14:59

Pull request has been modified.

@majanjua-amzn
Copy link
Contributor Author

majanjua-amzn commented Sep 26, 2025

Not sure what's going on here... I have "Allow edits by maintainers" set appropriately and the branch is not protected or anything. I tried rebasing manually the first time and then used the "Update branch" button this time and it resulted in the same, dequeueing my PR and dismissing the approval

@alvazjor
Copy link
Contributor

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Sep 29, 2025

refresh

✅ Pull request refreshed

@alvazjor
Copy link
Contributor

alvazjor commented Sep 29, 2025

Not sure what's going on here... I have "Allow edits by maintainers" set appropriately and the branch is not protected or anything. I tried rebasing manually the first time and then used the "Update branch" button this time and it resulted in the same, dequeueing my PR and dismissing the approval

Our merge tooling is acting up. Our team is already taking a look

@alvazjor
Copy link
Contributor

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Sep 29, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot added the queued label Sep 29, 2025
Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1d7076e into aws:main Sep 29, 2025
27 checks passed
@mergify mergify bot removed the queued label Sep 29, 2025
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants