-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(cloudfront): edgefunction does not propagate stack tags correctly #35518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudfront): edgefunction does not propagate stack tags correctly #35518
Conversation
…pagate stack tags correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
…s-not-propagate-stack-tags-correctly
…s-not-propagate-stack-tags-correctly
…s-not-propagate-stack-tags-correctly
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Mergifyio refresh |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
✅ Pull request refreshed |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio refresh |
✅ Pull request refreshed |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio refresh |
✅ Pull request refreshed |
This pull request has been removed from the queue for the following reason: Pull request #35518 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries. You can check the last failing draft PR here: #35619. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio refresh |
✅ Pull request refreshed |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: Pull request #35518 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries. You can check the last failing draft PR here: #35627. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…s-not-propagate-stack-tags-correctly
Pull request has been modified.
@Mergifyio refresh |
✅ Pull request refreshed |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
fix(cloudfront): cloudfront.experimental.edgefunction does not propagate stack tags correctly
Issue #35512
Closes #35512.
Reason for this change
cloudfront.experimental.edgefunction does not propagate stack tags correctly. When working in an organization that has policies requiring stack tags for allowing cloudformation create change set this causes issues during cdk deployment.
Description of changes
Added code for propagation of parent tags to the nested stack.
Describe any new or updated permissions being added
No extra permissions needed.
Description of how you validated changes
Added a unit test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license