Skip to content

Conversation

jstjnsn
Copy link
Contributor

@jstjnsn jstjnsn commented Sep 18, 2025

fix(cloudfront): cloudfront.experimental.edgefunction does not propagate stack tags correctly

Issue #35512

Closes #35512.

Reason for this change

cloudfront.experimental.edgefunction does not propagate stack tags correctly. When working in an organization that has policies requiring stack tags for allowing cloudformation create change set this causes issues during cdk deployment.

Description of changes

Added code for propagation of parent tags to the nested stack.

Describe any new or updated permissions being added

No extra permissions needed.

Description of how you validated changes

Added a unit test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 18, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 18, 2025 09:58
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Sep 18, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@jstjnsn jstjnsn changed the title fix(aws-cloudfront): cloudfront.experimental.edgefunction does not propagate stack tags correctly fix(cloudfront): cloudfront.experimental.edgefunction does not propagate stack tags correctly Sep 18, 2025
@ozelalisen ozelalisen self-assigned this Sep 29, 2025
@ozelalisen ozelalisen added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Sep 29, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 29, 2025 11:30

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

ozelalisen
ozelalisen previously approved these changes Sep 29, 2025
Copy link
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ozelalisen ozelalisen changed the title fix(cloudfront): cloudfront.experimental.edgefunction does not propagate stack tags correctly fix(cloudfront): edgefunction does not propagate stack tags correctly Sep 29, 2025
@mergify mergify bot added the queued label Sep 29, 2025
@ozelalisen
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot removed the queued label Sep 29, 2025
Copy link
Contributor

mergify bot commented Sep 29, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Contributor

mergify bot commented Sep 29, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot added the queued label Sep 29, 2025
Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot removed the queued label Sep 29, 2025
Copy link
Contributor

mergify bot commented Sep 29, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ozelalisen
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Sep 29, 2025

refresh

✅ Pull request refreshed

ozelalisen
ozelalisen previously approved these changes Sep 29, 2025
Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ozelalisen
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Sep 29, 2025

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Sep 29, 2025
Copy link
Contributor

mergify bot commented Sep 29, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35518 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries.
Waiting for the branch protection required status checks to be validated.

You can check the last failing draft PR here: #35619.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Sep 29, 2025
Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ozelalisen
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Sep 30, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot added the queued label Sep 30, 2025
mergify bot added a commit that referenced this pull request Sep 30, 2025
Copy link
Contributor

mergify bot commented Sep 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Sep 30, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35518 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries.
Waiting for the branch protection required status checks to be validated.

You can check the last failing draft PR here: #35627.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Sep 30, 2025
Copy link
Contributor

mergify bot commented Sep 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jstjnsn jstjnsn changed the title fix(cloudfront): edgefunction does not propagate stack tags correctly fix: cloudfront edgefunction does not propagate stack tags correctly Sep 30, 2025
@mergify mergify bot dismissed ozelalisen’s stale review September 30, 2025 07:46

Pull request has been modified.

@ozelalisen
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Sep 30, 2025

refresh

✅ Pull request refreshed

Copy link
Contributor

mergify bot commented Sep 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ozelalisen ozelalisen changed the title fix: cloudfront edgefunction does not propagate stack tags correctly fix(cloudfront): edgefunction does not propagate stack tags correctly Sep 30, 2025
Copy link
Contributor

mergify bot commented Sep 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ozelalisen ozelalisen merged commit 63088e8 into aws:main Sep 30, 2025
24 of 25 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudfront: experimental.EdgeFunction does not propagate tags correctly to stack
3 participants