Skip to content

Conversation

aemada-aws
Copy link
Contributor

@aemada-aws aemada-aws commented Sep 24, 2025

Reverts #35144

#35144 introduced a regression that removes support for cross account keys by only using the keyId instead of keyArn. This PR reverts that change.

Closes #35551

@github-actions github-actions bot added the p2 label Sep 24, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 24, 2025 17:19
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 24, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aemada-aws aemada-aws changed the title Revert "fix(dynamodb): use keyId instead of keyArn for TableV2 replica encryption" revert(dynamodb): use keyId instead of keyArn for TableV2 replica encryption Sep 25, 2025
@aemada-aws aemada-aws marked this pull request as ready for review September 25, 2025 08:11
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 25, 2025 08:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 25, 2025
@aemada-aws aemada-aws added p1 and removed p2 labels Sep 25, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 25, 2025
@ozelalisen ozelalisen self-assigned this Sep 25, 2025
Copy link
Contributor

mergify bot commented Sep 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Sep 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b1f7f78 into main Sep 25, 2025
19 checks passed
@mergify mergify bot deleted the revert-35144-fix-35136 branch September 25, 2025 08:53
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDb: Getting error while creating DDB using cross account kms key
3 participants