Skip to content

fix(certificatemanager): increase minimum validation total timeout #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 6, 2019
Merged

fix(certificatemanager): increase minimum validation total timeout #3914

merged 8 commits into from
Sep 6, 2019

Conversation

elhedran
Copy link
Contributor

@elhedran elhedran commented Sep 3, 2019 •
edited by eladb
Loading

Tests and fix to ensure minimum total wait time for validating dns validated certificates is sufficient for slower regions. Was 6 seconds, now at least 60 (but no more than 360).

Fixes #3912

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ianwaltersroames
fix(certificatemanager): add minimum backoff
e9558cb 
Add a minimum component to the backoff and retry timer
@ianwaltersroames
fix(certificatemanager): stub out sleep
f0cc195 
Provide stub function for sleep to allow long running sleep to
cause test to fail
@ianwaltersroames
fix(certificatemanager): spy on sleep
1bfdbb2 
spy on sleep function to determine total time attempted to sleep
@ianwaltersroames
fix(certificatemanager): Failing test
2115b52 
Failing test demonstrating min sleep is as low as 4.6 seconds.
@ianwaltersroames
fix(certificatemanager): increase attempts
98e0e1c 
Increase max attempts in validation, still under 10,
but such that minimum sleep duration of one minute is reached
(but not more than 3 minutes).

Can adjust tests if window is not suitable, but I find that at least
30 seconds is needed in my region
@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2019 •
edited by eladb
Loading

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@eladb
Copy link
Contributor

eladb commented Sep 3, 2019

Please check all the boxes in the PR checklist

@elhedran
Copy link
Contributor Author

elhedran commented Sep 3, 2019

Please check all the boxes in the PR checklist

Sorry, but I'm not sure what you mean. I don't seem to have rights to edit the bot's reply, but I have done each of the checks.

  • Testing has been added,
  • Docs not updated as it isn't a functional change
  • Titled the PR as per description
  • Not breaking, gave reason for change, indicated issue fixed
  • doesn't touch sensitive modules.

As near as I can tell 'checking all the boxes' means doing what they ask (done that) and also editing the bot's reply (I don't have permission). If it means something else could you please let me know? I haven't had experience with mergify before so I may be missing something obvious

@elhedran
Copy link
Contributor Author

elhedran commented Sep 5, 2019

image

@eladb - I assume I should see an 'edit' here if I had permission to check of the PR checklist?

@eladb eladb changed the title fix(certificatemanager): Fixes #3912 increase minimum validation total timeout fix(certificatemanager): increase minimum validation total timeout Sep 6, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 4973a8c into aws:master Sep 6, 2019
@yashutanna
Copy link

Hi! thanks for the fix. how would i make use of this configuration using aws-cdk@1.8.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eladb eladb eladb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minimum timeout for validating dnsvalidatedcertificates.
4 participants
@elhedran @eladb @yashutanna @ianwaltersroames